slight inconsistency in svn checkin email subject lines
Here are the subject lines for two recent svn commit emails: [Python-checkins] commit of r41847 - in python/trunk: Lib/test/test__locale.py Python/as... [Python-checkins] commit of r41848 - python/trunk/setup.py ^ `--- one extra space There is an extra space when the checkin includes exactly one file (at least, I think that is the condition). Is this intentional? If not, could someone point me to where the svn trigger scripts are maintained so I could poke around for a fix? (Or just fix it themselves. :) Cheers, Trent -- Trent Mick TrentM@ActiveState.com
Trent Mick wrote:
Is this intentional? If not, could someone point me to where the svn trigger scripts are maintained so I could poke around for a fix? (Or just fix it themselves. :)
It was not my intention. They are in dinsdale.python.org:/data/repos/projects Regards, Martin
[Martin v. Loewis wrote]
Trent Mick wrote:
Is this intentional? If not, could someone point me to where the svn trigger scripts are maintained so I could poke around for a fix? (Or just fix it themselves. :)
It was not my intention. They are in dinsdale.python.org:/data/repos/projects
I don't have access to that box. Is this a machine used for maintaining the pydotorg stuff? Do you want me in that "club"? Or would it be easier for you the fix this little inconsistency... or have me make a bug on SF and assign to you (or someone else)? Thanks, Trent -- Trent Mick trentm@activestate.com
Trent Mick wrote:
I don't have access to that box. Is this a machine used for maintaining the pydotorg stuff?
Yes, it's also www.python.org (but not mail.python.org)
Or would it be easier for you the fix this little inconsistency... or have me make a bug on SF and assign to you (or someone else)?
I tried to, but couldn't. I'll be sending the mailer.py and mailer.conf files in a private mail. I can't see anything wrong in that code. Perhaps mailman is adding the spaces? Regards, Martin
On 1/3/06, "Martin v. Löwis"
I tried to, but couldn't. I'll be sending the mailer.py and mailer.conf files in a private mail. I can't see anything wrong in that code.
Perhaps mailman is adding the spaces?
I looked into this briefly. I saw something like: if prefix: subject = prefix + ' ' + self.subject else: subject = self.subject My guess is that there needs to be stripping for prefix and self.subject. I don't know the code well, but that's all I could come up with. I didn't see any extra spaces in mailer.conf IIRC. n
Neal Norwitz wrote:
I looked into this briefly. I saw something like:
if prefix: subject = prefix + ' ' + self.subject else: subject = self.subject
Hmm - this shouldn't matter: There is only a single prefix defined, in [defaults]: commit_subject_prefix = [Python-checkins] commit of There is no other occurrence of that string in any other spelling elsewhere, and neither of the "commit of" part. So if prefix was empty, the entire "commit of" should be absent. Anyway, I just killed the "[Python-checkins]" part from the prefix (expecting that mailman would add it, anyway), and regenerated the r41848 commit message, and it seem that worked this time. So I still suspect this to be a mailman bug. There is just too much Python code involved in delivering Python commit messages :-) Regards, Martin
Martin v. Löwis wrote:
[...] commit_subject_prefix = [Python-checkins] commit of
[...]
Anyway, I just killed the "[Python-checkins]" part from the prefix (expecting that mailman would add it, anyway), and regenerated the r41848 commit message, and it seem that worked this time.
And while we're at it, could you remove the "commit of" too? IMHO it just obscures the real content of the subject. Bye, Walter Dörwald
Walter Dörwald wrote:
And while we're at it, could you remove the "commit of" too? IMHO it just obscures the real content of the subject.
Done. FYI, the rationale for this prefix was that post-commit distinguishes between "commit" and "revprop", where revprop would indicate that properties changed, not the contents. I just noticed that this is not actually post-commit, but that there is a second hook, post-revprop-change, which I hadn't filled out yet. I just created the hook; because I dropped the prefix, commit and revprop mails will have the same subject. Regards, Martin
participants (5)
-
"Martin v. Löwis" -
Neal Norwitz -
Raymond Hettinger -
Trent Mick -
Walter Dörwald