Desired changes to Hg emails to python-checkins
1) I miss not having the affected files listed in the subject line. 2) The To field is set to hg@python.org which gets rejected as an invalid email address if you reply. Would be better to set it to python-checkins so that the habitual reply to a checkin won't get rejected. At least I would like to see these changes happen. -Brett
On Thu, Mar 4, 2010 at 3:20 PM, Brett Cannon <brett@python.org> wrote:
1) I miss not having the affected files listed in the subject line. 2) The To field is set to hg@python.org which gets rejected as an invalid email address if you reply. Would be better to set it to python-checkins so that the habitual reply to a checkin won't get rejected.
I concur on both points. You are not alone. :-) -Fred -- Fred L. Drake, Jr. <fdrake at gmail.com> "Chaos is the score upon which reality is written." --Henry Miller
Brett Cannon wrote:
1) I miss not having the affected files listed in the subject line.
2) The To field is set to hg@python.org <mailto:hg@python.org> which gets rejected as an invalid email address if you reply. Would be better to set it to python-checkins so that the habitual reply to a checkin won't get rejected.
At least I would like to see these changes happen.
+1 (and it's OK if the file list gets truncated for big checkins - it's still handy in typical cases) Cheers, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia ---------------------------------------------------------------
Are the diffs gone for some deliberate reason? I realize the link tells me the changes, but I'll review a lot more code if the diffs show up in my inbox than if I have to fire up a browser, especially from my phone. Eric. Brett Cannon wrote:
1) I miss not having the affected files listed in the subject line.
2) The To field is set to hg@python.org <mailto:hg@python.org> which gets rejected as an invalid email address if you reply. Would be better to set it to python-checkins so that the habitual reply to a checkin won't get rejected.
At least I would like to see these changes happen.
-Brett
------------------------------------------------------------------------
_______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/eric%2Ba-python-dev%40true...
-- Eric.
On Mar 04, 2010, at 03:43 PM, Eric Smith wrote:
Are the diffs gone for some deliberate reason?
I realize the link tells me the changes, but I'll review a lot more code if the diffs show up in my inbox than if I have to fire up a browser, especially from my phone.
Agreed, please restore the diffs! -Barry
Brett Cannon wrote:
1) I miss not having the affected files listed in the subject line.
2) The To field is set to hg@python.org <mailto:hg@python.org> which gets rejected as an invalid email address if you reply. Would be better to set it to python-checkins so that the habitual reply to a checkin won't get rejected.
At least I would like to see these changes happen.
I'd like to keep the inline diffs as well - much easier to skim patches as I click through messages, whereas links to changesets, while useful if I decide to look at a change in more detail, don't tell me a lot at a glance. Cheers, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia ---------------------------------------------------------------
First off, this was just a first sample, it was by no means the definitive format. Second, the diffs are already back, in the next message (this first one was per changegroup, not per changeset -- new ones will be per changeset). On Thu, Mar 4, 2010 at 21:20, Brett Cannon <brett@python.org> wrote:
1) I miss not having the affected files listed in the subject line.
Well, I think it looks rather ugly, and Tarek said he'd like the first line of the commit message in the subject instead, so that's what I've implemented right now. But then if there's a majority who want the files, I'm happy to put them back.
2) The To field is set to hg@python.org which gets rejected as an invalid email address if you reply. Would be better to set it to python-checkins so that the habitual reply to a checkin won't get rejected.
Will fix. Cheers, Dirkjan
2010/3/4 Dirkjan Ochtman <dirkjan@ochtman.nl>:
Well, I think it looks rather ugly, and Tarek said he'd like the first line of the commit message in the subject instead, so that's what I've implemented right now. But then if there's a majority who want the files, I'm happy to put them back.
+1 to bringing back affected files. It helps tell at a glance whether a changeset is interesting or not. -- Regards, Benjamin
On Thu, Mar 4, 2010 at 22:44, Benjamin Peterson <benjamin@python.org> wrote:
+1 to bringing back affected files. It helps tell at a glance whether a changeset is interesting or not.
Do they need to be in the subject, or would it be fine to have them in the message? Cheers, Dirkjan
2010/3/4 Dirkjan Ochtman <dirkjan@ochtman.nl>:
On Thu, Mar 4, 2010 at 22:44, Benjamin Peterson <benjamin@python.org> wrote:
+1 to bringing back affected files. It helps tell at a glance whether a changeset is interesting or not.
Do they need to be in the subject, or would it be fine to have them in the message?
Both is good actually. -- Regards, Benjamin
On Thu, Mar 4, 2010 at 13:56, Benjamin Peterson <benjamin@python.org> wrote:
2010/3/4 Dirkjan Ochtman <dirkjan@ochtman.nl>:
On Thu, Mar 4, 2010 at 22:44, Benjamin Peterson <benjamin@python.org> wrote:
+1 to bringing back affected files. It helps tell at a glance whether a changeset is interesting or not.
Do they need to be in the subject, or would it be fine to have them in the message?
Both is good actually.
I prefer the subject so that I can easily skim them to see if someone edited a file I really care about, but if that is not possible then the body is acceptable, especially if it is the first thing in the body (that would let me at least see some of it in the initial snippet Gmail shows). -Brett
-- Regards, Benjamin
Brett Cannon writes:
I prefer the subject so that I can easily skim them to see if someone edited a file I really care about, but if that is not possible then the body is acceptable, especially if it is the first thing in the body (that would let me at least see some of it in the initial snippet Gmail shows).
I don't know if it's pedantically RFC-correct, but occasionally you'll see a Summary field in the header. I think using the first line of the log in the Subject field and the file list as the Summary field would be a good way to do it, *if* people's MUAs would display Summary. I suspect they don't (mine does, but mine does a lot of nifty things that cellphone MUAs don't :-( ).
Am 04.03.2010 21:20, schrieb Brett Cannon:
1) I miss not having the affected files listed in the subject line.
I actually like the (first line of the) commit message better. It communicates much better what the change is about (and for me, if I want to look at/review it). However, what I miss is the summary of affected files at the top of the message. Having to scroll down all of the diffs to find out if e.g. a change to a documentation file is included is tedious, even if the diffs are colored like they are for me.
2) The To field is set to hg@python.org <mailto:hg@python.org> which gets rejected as an invalid email address if you reply. Would be better to set it to python-checkins so that the habitual reply to a checkin won't get rejected.
+1. Georg
Am 04.03.2010 21:20, schrieb Brett Cannon:
1) I miss not having the affected files listed in the subject line.
2) The To field is set to hg@python.org <mailto:hg@python.org> which gets rejected as an invalid email address if you reply. Would be better to set it to python-checkins so that the habitual reply to a checkin won't get rejected.
Before I forget: for CPython, if all branches are to be in one hg repo with named branches, the branch name also needs to be in the subject line. Georg -- Thus spake the Lord: Thou shalt indent with four spaces. No more, no less. Four shall be the number of spaces thou shalt indent, and the number of thy indenting shall be four. Eight shalt thou not indent, nor either indent thou two, excepting that thou then proceed to four. Tabs are right out.
participants (9)
-
Barry Warsaw -
Benjamin Peterson -
Brett Cannon -
Dirkjan Ochtman -
Eric Smith -
Fred Drake -
Georg Brandl -
Nick Coghlan -
Stephen J. Turnbull