Re: [Python-checkins] python/dist/src/Modules ossaudiodev.c, 1.35, 1.36
Greg, Um, unless I misread this, you added new attributes to the ossaudiodev objects in the 2.4 branch. Please don't do this - this is a new feature, and suddenly people who want to use those new attributes have to either test for version
= 2.4.1, or else do a hasattr test. Please see the bugfix PEP for more rationale on this...
Anthony
--
Anthony Baxter
On 07 March 2005, Anthony Baxter said:
Um, unless I misread this, you added new attributes to the ossaudiodev objects in the 2.4 branch. Please don't do this - this is a new feature, and suddenly people who want to use those new attributes have to either test for version >= 2.4.1, or else do a hasattr test. Please see the bugfix PEP for more rationale on this...
D'ohhh -- busted! My only excuse is that the lack of these attributes
was originally filed as a bug report, and I suddenly realized "oops! new
attributes == feature request" just as I was checking the change in on
2.4.
I'll revert the change on 2.4 if you (or anyone) really wants me to.
Otherwise, I'd rather leave it as-is and go fix more bugs.
Greg
--
Greg Ward
On Mon, Mar 07, 2005, Greg Ward wrote:
D'ohhh -- busted! My only excuse is that the lack of these attributes was originally filed as a bug report, and I suddenly realized "oops! new attributes == feature request" just as I was checking the change in on 2.4.
I'll revert the change on 2.4 if you (or anyone) really wants me to. Otherwise, I'd rather leave it as-is and go fix more bugs.
Please revert. I've spent more time than I'd like dealing with the introduction of booleans in Python 2.2, and helping other people avoid similar problems seems like a Good Thing to me. -- Aahz (aahz@pythoncraft.com) <*> http://www.pythoncraft.com/ "The joy of coding Python should be in seeing short, concise, readable classes that express a lot of action in a small amount of clear code -- not in reams of trivial code that bores the reader to death." --GvR
On Tuesday 08 March 2005 12:14, Greg Ward wrote:
D'ohhh -- busted! My only excuse is that the lack of these attributes was originally filed as a bug report, and I suddenly realized "oops! new attributes == feature request" just as I was checking the change in on 2.4.
I'll revert the change on 2.4 if you (or anyone) really wants me to. Otherwise, I'd rather leave it as-is and go fix more bugs.
I really would like to see it reverted, please.
Thanks,
Anthony
--
Anthony Baxter
On 08 March 2005, Anthony Baxter said:
I really would like to see it reverted, please.
Done.
Greg
--
Greg Ward
participants (3)
-
Aahz -
Anthony Baxter -
Greg Ward