RE: [Python-checkins] python/dist/src/Modules posixmodule.c, 2.300.8.10, 2.300.8.11
The Dec 12th check-ins break tests on WinME:
test_glob.py ------------ Traceback (most recent call last): File "test_glob.py", line 78, in test_glob_one_directory eq(self.glob('a*'), map(self.norm, ['a', 'aab', 'aaa'])) File "test_glob.py", line 67, in assertSequencesEqual_noorder self.assertEqual(set(l1), set(l2)) AssertionError: set(['/tmp\@test_dir\aaa', '/tmp\@test_dir\aab', '/tmp\@tes t_dir\a']) != set(['\tmp\@test_dir\aab', '\tmp\@test_dir\aaa', '\tmp\@t est_dir\a'])
test_urllib.py -------------- FAIL: test_basic (__main__.urlretrieve_FileTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "test_urllib.py", line 142, in test_basic self.assertEqual(result[0], test_support.TESTFN) AssertionError: '\tmp\@test' != '/tmp\@test'
Please fix,
Raymond
-----Original Message----- From: python-checkins-bounces@python.org [mailto:python-checkins- bounces@python.org] On Behalf Of aimacintyre@users.sourceforge.net Sent: Sunday, December 12, 2004 3:37 AM To: python-checkins@python.org Subject: [Python-checkins] python/dist/src/Modules posixmodule.c, 2.300.8.10, 2.300.8.11
Update of /cvsroot/python/python/dist/src/Modules In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv12893
Modified Files: Tag: release23-maint posixmodule.c Log Message: OS/2 specific fixes related to SF bug # 1003471.
Also revise a related function to minimise file handle/pipe leakage and improve reliability.
Backported from -HEAD.
On Fri, 17 Dec 2004, Raymond Hettinger wrote:
The Dec 12th check-ins break tests on WinME:
test_glob.py
Traceback (most recent call last): File "test_glob.py", line 78, in test_glob_one_directory eq(self.glob('a*'), map(self.norm, ['a', 'aab', 'aaa'])) File "test_glob.py", line 67, in assertSequencesEqual_noorder self.assertEqual(set(l1), set(l2)) AssertionError: set(['/tmp\@test_dir\aaa', '/tmp\@test_dir\aab', '/tmp\@tes t_dir\a']) != set(['\tmp\@test_dir\aab', '\tmp\@test_dir\aaa', '\tmp\@t est_dir\a'])
test_urllib.py
FAIL: test_basic (__main__.urlretrieve_FileTests)
Traceback (most recent call last): File "test_urllib.py", line 142, in test_basic self.assertEqual(result[0], test_support.TESTFN) AssertionError: '\tmp\@test' != '/tmp\@test'
Please fix,
????
I don't see any possible way for those checkins to affect any platform other than OS/2.
2 of the files are platform specific files (PC/os2emx/getpath.c, PC/os2vacpp/getpath.c), and the checkin to Modules/posixmodule.c is contained within a platform specific #if/#endif:
... #ifdef HAVE_POPEN <<<-- line 3241 ... #if defined(PYOS_OS2) #if defined(PYCC_VACPP) ... <<<-- changes here #elif defined(PYCC_GCC) ... #endif /* PYCC_??? */ #elif defined(MS_WINDOWS) ... #else /* which OS? */ ... #endif /* PYOS_??? */ #endif /* HAVE_POPEN */ ...
Note that the posixmodule change affects popen().
The matching PC/getpath.c changes that apply to Windows were checked in by Tim Peters back in August.
I don't have any Windows development environment, so can't cross check your report :-(
If you have verified the cause of failure by backing out v2.300.8.11, then there's a deeper problem about the Windows build picking up explicitly non-Windows components - which I find hard to believe.
In the absence of more evidence, not guilty your honour.
------------------------------------------------------------------------- Andrew I MacIntyre "These thoughts are mine alone..." E-mail: andymac@bullseye.apana.org.au (pref) | Snail: PO Box 370 andymac@pcug.org.au (alt) | Belconnen ACT 2616 Web: http://www.andymac.org/ | Australia
Andrew MacIntyre wrote:
I don't see any possible way for those checkins to affect any platform other than OS/2.
2 of the files are platform specific files (PC/os2emx/getpath.c, PC/os2vacpp/getpath.c), and the checkin to Modules/posixmodule.c is contained within a platform specific #if/#endif:
Perhaps, but if you look at line 3299 you will notice that a comment is started but not closed off before the next comment on line 3304. How is that comment supposed to be closed off?
-Brett
[Raymond, says test_glob and test_urllib fail on WinME now]
[Andrew MacIntyre]
I don't see any possible way for those checkins to affect any platform other than OS/2.
2 of the files are platform specific files (PC/os2emx/getpath.c, PC/os2vacpp/getpath.c), and the checkin to Modules/posixmodule.c is contained within a platform specific #if/#endif:
[Brett]
Perhaps, but if you look at line 3299 you will notice that a comment is started but not closed off before the next comment on line 3304. How is that comment supposed to be closed off?
That's obviously a bug, and was introduced by the patch. Andrew wanted
/* setup the pipe */
not
/* setup the pipe
But we don't get there unless PYOS_OS2 and PYCC_VACPP are defined, so that can't explain Raymond's problem.
FWIW, the tests at issue pass on WinXP for me today w/ current CVS.
On Sat, 18 Dec 2004, Tim Peters wrote:
[Raymond, says test_glob and test_urllib fail on WinME now]
[Andrew MacIntyre]
I don't see any possible way for those checkins to affect any platform other than OS/2.
2 of the files are platform specific files (PC/os2emx/getpath.c, PC/os2vacpp/getpath.c), and the checkin to Modules/posixmodule.c is contained within a platform specific #if/#endif:
[Brett]
Perhaps, but if you look at line 3299 you will notice that a comment is started but not closed off before the next comment on line 3304. How is that comment supposed to be closed off?
That's obviously a bug, and was introduced by the patch. Andrew wanted
/* setup the pipe */
not
/* setup the pipe
Fair cop guv.
Long exposure to a language with comments of the latter form has been a PITA at times. :-(
But we don't get there unless PYOS_OS2 and PYCC_VACPP are defined, so that can't explain Raymond's problem.
FWIW, the tests at issue pass on WinXP for me today w/ current CVS.
Good, though Raymond's report appeared to be focussed on the 2.3 branch.
------------------------------------------------------------------------- Andrew I MacIntyre "These thoughts are mine alone..." E-mail: andymac@bullseye.apana.org.au (pref) | Snail: PO Box 370 andymac@pcug.org.au (alt) | Belconnen ACT 2616 Web: http://www.andymac.org/ | Australia
participants (4)
-
Andrew MacIntyre -
Brett C. -
Raymond Hettinger -
Tim Peters