Adding GitHub usernames to the developer log
Recently, Brett updated the developer log in the devguide (https://devguide.python.org/developers/) to fetch the names of each core developer and the date they were given commit privileges from the private python-committers repository. I think it would also be quite useful to include GitHub usernames on that list. Currently, the only list that contributors can find the GitHub usernames for each core developer is through the committers list on bpo. Since we will be moving away from bpo (PEP 581), we should have a comprehensive list that is separate from that platform. The motivation behind creating a a new topic for this issue was Brett's response to my comment in the PR that updated the devguide (https://github.com/python/devguide/pull/533#issuecomment-532405907). Essentially, if no core developers have an issue with having their GitHub username posted on the devguide, we can move forward with adding it. Another related but more long term project is adding the GitHub usernames to the experts index (https://devguide.python.org/experts/). This is more involved because the bpo nosy list currently pulls from the experts index, meaning the nosy list is dependent on the specific formatting used. To address this, I opened a PR a couple of months ago which would add a .json file containing the data from the experts index (https://github.com/python/devguide/pull/517), based on the discussion in the related issue (https://github.com/python/devguide/issues/507). If any available core developers are experienced with structuring .json files, I would greatly appreciate any feedback. The next step would be converting the nosy list script to use the new .json file instead of the experts index page, so that we could adjust the page to also include GitHub usernames. Optimally, the contents in the experts index would be pulled from the .json file automatically so any changes only have to be made to a single location.
Le mer. 25 sept. 2019 à 08:24, Kyle Stanley <aeros167@gmail.com> a écrit :
Recently, Brett updated the developer log in the devguide (https://devguide.python.org/developers/) to fetch the names of each core developer and the date they were given commit privileges from the private python-committers repository.
devguide now uses developers.rst which is generated from the following private file: https://github.com/python/voters/blob/master/python-core.toml The TOML file contains developer identifiers for: * GitHub * bugs.python.org (Roundup) * discuss.python.org (Discourse)
The motivation behind creating a a new topic for this issue was Brett's response to my comment in the PR that updated the devguide (https://github.com/python/devguide/pull/533#issuecomment-532405907). Essentially, if no core developers have an issue with having their GitHub username posted on the devguide, we can move forward with adding it.
I'm in favor of making the GitHub identifiers public since it's part of the trust relationship between core developers and contributors. Some operations in our workflow *requires* a core developer on GitHub pull requests. So it's good to be able to check who are core developers on GitHub. Guessing a GitHub identifier from a real name is not really easy. The GitHub identifer can be *guessed* using the public bugs.python.org data. For example, I'm user 2377 on bugs.python.org which shows that my GitHub identifier is vstinner: https://bugs.python.org/user2377 "Is Committer [hidden]" doesn't help to check if it's real or a fake account :-/ Some core developers have multiple bugs.python.org accounts. Note: I changed my bugs.python.org and GitHub identifiers one year ago from "haypo" to "vstinner" :-) It seems like https://github.com/orgs/python/teams/python-core/members is private. Victor -- Night gathers, and now my watch begins. It shall not end until my death.
I'm personally fine listing GItHub usernames in the devguide's developer list, but I'm also not trying to be anonymous on GitHub. But I will say that listing our GitHub usernames with our real names is not required to tell who is a core developer. In GitHub's UI there are multiple places it will tell you if a person is a member of the repository/team (e.g. hover cards, each comment a teammate makes).
But I will say that listing our GitHub usernames with our real names is not required to tell who is a core developer. In GitHub's UI there are multiple places it will tell you if a person is a member of the repository/team
Within the GitHub UI if you're not a member of the organization, it tells you who's a member of the org, but it does _not_ tell you what specific team they're on. There are close to 100 people that are in the Python organization on various teams but not a member of python-core. This includes anyone on the more recently created python-triage team or any of the PSF teams. I only became aware of this more recently, I'm not sure as to whether or not it's a configurable setting that is modifiable by the organization admins. To verify this, simply log out of your GitHub account and go into a PR with multiple organization members. Hovering over their name will show "Member of Python" but not the actual name of the team(s) they're on. For a recent example, logout of your GitHub account, go to PR-16375 ( https://github.com/python/cpython/pull/16375), then compare the hover cards between myself and Yury. Many people have their role within the organization mentioned in their GitHub bio (which appears on the hover card), but this is not always the case. It's also very useful when trying to find a specific core developer, particularly when trying to locate the GitHub usernames for specific experts. Locating the GitHub usernames of the experts is a bit of a separate issue, but having the usernames listed on the developer log would at least make it easier to do so without relying on bpo. On Wed, Sep 25, 2019 at 12:48 PM Brett Cannon <brett@python.org> wrote:
I'm personally fine listing GItHub usernames in the devguide's developer list, but I'm also not trying to be anonymous on GitHub.
But I will say that listing our GitHub usernames with our real names is not required to tell who is a core developer. In GitHub's UI there are multiple places it will tell you if a person is a member of the repository/team (e.g. hover cards, each comment a teammate makes). _______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-leave@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/KOKMLHX4...
Since Victor and I came out in support of listing everyone's GitHub usernames in the devguide and no one objected, I will assume people are okay with this idea. And so at some point I will update the code to generate the table for the devguide to include everyone's GitHub username.
devguide now uses developers.rst which is generated from the following private file: https://github.com/python/voters/blob/master/python-core.toml
Ah good to know. I don't have access to the voters repo so I wasn't sure about the exact format or location of the file.
Guessing a GitHub identifier from a real name is not really easy.
Yeah that's my main concern, particularly for new contributors trying to find or identify a specific core developer. For some people it's quite easy when it matches up with their real name (such as yourself and Brett for example). But for others it's definitely not obvious, especially when their real name isn't included in any part of their username. I admit that I'm guilty of this myself with using "aeros167" instead of "kstanley" or something along those lines (I had my GitHub account for a decent while before I started contributing to Python). This would be a non-issue with a public listing of core developer real names -> GitHub usernames that isn't dependent on bpo. On Wed, Sep 25, 2019 at 7:12 AM Victor Stinner <vstinner@python.org> wrote:
Le mer. 25 sept. 2019 à 08:24, Kyle Stanley <aeros167@gmail.com> a écrit :
Recently, Brett updated the developer log in the devguide (https://devguide.python.org/developers/) to fetch the names of each core developer and the date they were given commit privileges from the private python-committers repository.
devguide now uses developers.rst which is generated from the following private file: https://github.com/python/voters/blob/master/python-core.toml
The TOML file contains developer identifiers for:
* GitHub * bugs.python.org (Roundup) * discuss.python.org (Discourse)
The motivation behind creating a a new topic for this issue was Brett's response to my comment in the PR that updated the devguide (https://github.com/python/devguide/pull/533#issuecomment-532405907). Essentially, if no core developers have an issue with having their GitHub username posted on the devguide, we can move forward with adding it.
I'm in favor of making the GitHub identifiers public since it's part of the trust relationship between core developers and contributors. Some operations in our workflow *requires* a core developer on GitHub pull requests. So it's good to be able to check who are core developers on GitHub.
Guessing a GitHub identifier from a real name is not really easy.
The GitHub identifer can be *guessed* using the public bugs.python.org data. For example, I'm user 2377 on bugs.python.org which shows that my GitHub identifier is vstinner: https://bugs.python.org/user2377
"Is Committer [hidden]" doesn't help to check if it's real or a fake account :-/ Some core developers have multiple bugs.python.org accounts.
Note: I changed my bugs.python.org and GitHub identifiers one year ago from "haypo" to "vstinner" :-)
It seems like https://github.com/orgs/python/teams/python-core/members is private.
Victor -- Night gathers, and now my watch begins. It shall not end until my death.
participants (3)
-
Brett Cannon -
Kyle Stanley -
Victor Stinner