Re: [Python-Dev] [Python-checkins] cpython: Fix #13327. Remove the need for an explicit None as the second argument to
2011/11/6 brian.curtin <python-checkins@python.org>:
- - if (!PyArg_ParseTuple(args, "O&O:utime", + PyObject* arg = NULL;
You could set arg = Py_None here.
+ + if (!PyArg_ParseTuple(args, "O&|O:utime", PyUnicode_FSConverter, &opath, &arg)) return NULL; path = PyBytes_AsString(opath); - if (arg == Py_None) { + if (!arg || (arg == Py_None)) {
And then not have to change this. -- Regards, Benjamin
On Sun, Nov 6, 2011 at 13:46, Benjamin Peterson <benjamin@python.org> wrote:
2011/11/6 brian.curtin <python-checkins@python.org>:
- - if (!PyArg_ParseTuple(args, "O&O:utime", + PyObject* arg = NULL;
You could set arg = Py_None here.
+ + if (!PyArg_ParseTuple(args, "O&|O:utime", PyUnicode_FSConverter, &opath, &arg)) return NULL; path = PyBytes_AsString(opath); - if (arg == Py_None) { + if (!arg || (arg == Py_None)) {
And then not have to change this.
Ah, good point. I'm going to be making this same change to the other functions in utime family, so I'll look at updating this one and change the others accordingly.
participants (2)
-
Benjamin Peterson -
Brian Curtin