cross-compiling patches

Hello, I think these patches are premature (they break compilation on OS X, and they break ctypes configure on my Linux box). Furthermore, they were committed post-beta, which means they should probably have waited for after the 3.3 release. So I propose for these commits to be reverted. (to be clear, I'm talking about all configure / Makefile / setup.py / libffi changes since and including http://hg.python.org/cpython/rev/e6e99d449bdc876fa57111e7e534c44ecbc3bcbd ) Regards Antoine.

On 30.06.2012 23:17, Antoine Pitrou wrote:
that was unrelated. fixed last night.
somebody (?) asked on irc that either Martin or I should update the internal copies, and someone suggested to do the same with the expat sources. And I asked our release manager if he was ok with this post beta change.
the first cross-build fixes went in in April, please consider these fixes for the then incomplete cros-build fixes. The build issues you did see last night, were fixed for the OS X build, and I reverted the update for the compiler search paths for the native build. So please lets keep this cross-build support for 3.3. It's working, tested with a arm-linux-gnueabi build on x86_64-linux-gnu. Matthias

On 01.07.2012 10:22, Matthias Klose wrote:
It's also something the buildbots can catch easily.
FWIW, I agree that build fixes for platforms we already support are not a new feature. I am not happy about the amount of changes, and I hope that no such big changes will come until final now... Georg

On 30.06.2012 23:17, Antoine Pitrou wrote:
that was unrelated. fixed last night.
somebody (?) asked on irc that either Martin or I should update the internal copies, and someone suggested to do the same with the expat sources. And I asked our release manager if he was ok with this post beta change.
the first cross-build fixes went in in April, please consider these fixes for the then incomplete cros-build fixes. The build issues you did see last night, were fixed for the OS X build, and I reverted the update for the compiler search paths for the native build. So please lets keep this cross-build support for 3.3. It's working, tested with a arm-linux-gnueabi build on x86_64-linux-gnu. Matthias

On 01.07.2012 10:22, Matthias Klose wrote:
It's also something the buildbots can catch easily.
FWIW, I agree that build fixes for platforms we already support are not a new feature. I am not happy about the amount of changes, and I hope that no such big changes will come until final now... Georg
participants (4)
-
Antoine Pitrou
-
Georg Brandl
-
Matthias Klose
-
Nick Coghlan