Hello,
I think these patches are premature (they break compilation on OS X, and they break ctypes configure on my Linux box). Furthermore, they were committed post-beta, which means they should probably have waited for after the 3.3 release. So I propose for these commits to be reverted.
(to be clear, I'm talking about all configure / Makefile / setup.py / libffi changes since and including http://hg.python.org/cpython/rev/e6e99d449bdc876fa57111e7e534c44ecbc3bcbd )
Regards
Antoine.
On 30.06.2012 23:17, Antoine Pitrou wrote:
Hello,
I think these patches are premature (they break compilation on OS X, and they break ctypes configure on my Linux box).
that was unrelated. fixed last night.
Furthermore, they were committed post-beta, which means they should probably have waited for after the 3.3 release. So I propose for these commits to be reverted.
somebody (?) asked on irc that either Martin or I should update the internal copies, and someone suggested to do the same with the expat sources. And I asked our release manager if he was ok with this post beta change.
(to be clear, I'm talking about all configure / Makefile / setup.py / libffi changes since and including http://hg.python.org/cpython/rev/e6e99d449bdc876fa57111e7e534c44ecbc3bcbd )
the first cross-build fixes went in in April, please consider these fixes for the then incomplete cros-build fixes. The build issues you did see last night, were fixed for the OS X build, and I reverted the update for the compiler search paths for the native build. So please lets keep this cross-build support for 3.3. It's working, tested with a arm-linux-gnueabi build on x86_64-linux-gnu.
Matthias
On Sun, Jul 1, 2012 at 6:22 PM, Matthias Klose doko@ubuntu.com wrote:
the first cross-build fixes went in in April, please consider these fixes for the then incomplete cros-build fixes. The build issues you did see last night, were fixed for the OS X build, and I reverted the update for the compiler search paths for the native build. So please lets keep this cross-build support for 3.3. It's working, tested with a arm-linux-gnueabi build on x86_64-linux-gnu.
Indeed, especially with the variety of ARM mini-boards coming onto the market at the moment.
Cheers, Nick.
On 01.07.2012 10:22, Matthias Klose wrote:
On 30.06.2012 23:17, Antoine Pitrou wrote:
Hello,
I think these patches are premature (they break compilation on OS X, and they break ctypes configure on my Linux box).
that was unrelated. fixed last night.
It's also something the buildbots can catch easily.
Furthermore, they were committed post-beta, which means they should probably have waited for after the 3.3 release. So I propose for these commits to be reverted.
somebody (?) asked on irc that either Martin or I should update the internal copies, and someone suggested to do the same with the expat sources. And I asked our release manager if he was ok with this post beta change.
(to be clear, I'm talking about all configure / Makefile / setup.py / libffi changes since and including http://hg.python.org/cpython/rev/e6e99d449bdc876fa57111e7e534c44ecbc3bcbd )
the first cross-build fixes went in in April, please consider these fixes for the then incomplete cros-build fixes. The build issues you did see last night, were fixed for the OS X build, and I reverted the update for the compiler search paths for the native build. So please lets keep this cross-build support for 3.3. It's working, tested with a arm-linux-gnueabi build on x86_64-linux-gnu.
FWIW, I agree that build fixes for platforms we already support are not a new feature. I am not happy about the amount of changes, and I hope that no such big changes will come until final now...
Georg
On Sun, 01 Jul 2012 11:37:50 +0200 Georg Brandl g.brandl@gmx.net wrote:
the first cross-build fixes went in in April, please consider these fixes for the then incomplete cros-build fixes. The build issues you did see last night, were fixed for the OS X build, and I reverted the update for the compiler search paths for the native build. So please lets keep this cross-build support for 3.3. It's working, tested with a arm-linux-gnueabi build on x86_64-linux-gnu.
FWIW, I agree that build fixes for platforms we already support are not a new feature. I am not happy about the amount of changes, and I hope that no such big changes will come until final now...
I don't think we have ever supported cross-compiling officially (which is different from supporting a given platform, e.g. ARM). But fair enough.
Regards
Antoine.
-
Antoine Pitrou -
Georg Brandl -
Matthias Klose -
Nick Coghlan