Neal Norwitz schrieb:

On 5/26/07, Peter Åstrand <astrand@cendio.se> wrote:

...

I'm unable to commit tonight:

Sending Doc/lib/libsubprocess.tex Sending Lib/subprocess.py Sending Lib/test/test_subprocess.py Transmitting file data ...svn: Commit failed (details follow): svn: 'pre-commit' hook failed with error output: Traceback (most recent call last): File "/data/repos/projects/hooks/checkwhitespace.py", line 50, in ? run_app(main) File "/usr/lib/python2.3/site-packages/svn/core.py", line 33, in run_app return apply(func, (pool,) + args, kw) File "/data/repos/projects/hooks/checkwhitespace.py", line 32, in main if fs.node_prop(txn_root, path, 'svn:special') == '*': continue TypeError: svn_fs_node_prop() takes exactly 4 arguments (3 given)

Any ideas?

I tried to fix it so you can check in links, but that didn't work. I commented out the change, so you should be able to commit again.

Odd... the call worked here (SVN 1.4.3). Which version is the server using? Georg -- Thus spake the Lord: Thou shalt indent with four spaces. No more, no less. Four shall be the number of spaces thou shalt indent, and the number of thy indenting shall be four. Eight shalt thou not indent, nor either indent thou two, excepting that thou then proceed to four. Tabs are right out.

I don't know. After some Googling, I found that the call might need to be:

if fs.node_prop(txn_root, path, SVN_PROP_MIME_TYPE, 'svn:special') == '*': continue

No. Instead, the missing argument was the apr_pool_t parameter, which was mandatory earlier, and is optional in current releases. The requirement to pass an apr_pool_t is answered by putting the entire logic into a single callback function that expects a pool, and then passing the pool to all API functions as the last parameter. The callback itself is passed to run_app. I have fixed the hook, and tested that it still checks regular .py files, but skips them if they are svn:special. Regards, Martin

Martin v. Löwis schrieb:

...

Odd... the call worked here (SVN 1.4.3). Which version is the server using?

1.1. Subversion did a grand renaming at some point. I fixed most of the functions when deploying the script, but apparently missed some.

Okay. Is an upgrade planned? I've heard that several actions were sped up significantly with later releases. Georg -- Thus spake the Lord: Thou shalt indent with four spaces. No more, no less. Four shall be the number of spaces thou shalt indent, and the number of thy indenting shall be four. Eight shalt thou not indent, nor either indent thou two, excepting that thou then proceed to four. Tabs are right out.