Oodles of warnings in cjkcodecs

Under MSVC 6, tons of new warnings are generated for these new files. Then all the new tests fail on Win98SE, with errors like: LookupError: unknown encoding: shift_jisx0213 New warnings: multibytecodec.c _cp932.c C:\Code\python\Modules\cjkcodecs\_cp932.c(23) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data _cp949.c C:\Code\python\Modules\cjkcodecs\_cp949.c(21) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data _cp950.c C:\Code\python\Modules\cjkcodecs\_cp950.c(22) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data _euc_jisx0213.c _euc_jp.c C:\Code\python\Modules\cjkcodecs\_euc_jisx0213.c(47) : warning C4761: integral size mismatch in argument; conversion supplied C:\Code\python\Modules\cjkcodecs\_euc_jisx0213.c(54) : warning C4761: integral size mismatch in argument; conversion supplied C:\Code\python\Modules\cjkcodecs\_euc_jisx0213.c(57) : warning C4761: integral size mismatch in argument; conversion supplied C:\Code\python\Modules\cjkcodecs\_euc_jp.c(21) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data _euc_kr.c C:\Code\python\Modules\cjkcodecs\_euc_kr.c(20) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data _gb18030.c _gb2312.c C:\Code\python\Modules\cjkcodecs\_gb2312.c(20) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data _gbk.c C:\Code\python\Modules\cjkcodecs\_gbk.c(22) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data _hz.c C:\Code\python\Modules\cjkcodecs\_hz.c(39) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data C:\Code\python\Modules\cjkcodecs\_hz.c(42) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data _iso2022_jp.c C:\Code\python\Modules\cjkcodecs\iso2022common.h(189) : warning C4018: '>=' : signed/unsigned mismatch C:\Code\python\Modules\cjkcodecs\iso2022common.h(196) : warning C4018: '<' : signed/unsigned mismatch C:\Code\python\Modules\cjkcodecs\_iso2022_jp.c(52) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data C:\Code\python\Modules\cjkcodecs\_iso2022_jp.c(64) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data C:\Code\python\Modules\cjkcodecs\_iso2022_jp.c(80) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data C:\Code\python\Modules\cjkcodecs\_iso2022_jp.c(104) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data _iso2022_jp_1.c C:\Code\python\Modules\cjkcodecs\iso2022common.h(189) : warning C4018: '>=' : signed/unsigned mismatch C:\Code\python\Modules\cjkcodecs\iso2022common.h(196) : warning C4018: '<' : signed/unsigned mismatch C:\Code\python\Modules\cjkcodecs\_iso2022_jp_1.c(54) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data C:\Code\python\Modules\cjkcodecs\_iso2022_jp_1.c(66) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data C:\Code\python\Modules\cjkcodecs\_iso2022_jp_1.c(82) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data C:\Code\python\Modules\cjkcodecs\_iso2022_jp_1.c(113) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data _iso2022_jp_2.c C:\Code\python\Modules\cjkcodecs\iso2022common.h(189) : warning C4018: '>=' : signed/unsigned mismatch C:\Code\python\Modules\cjkcodecs\iso2022common.h(196) : warning C4018: '<' : signed/unsigned mismatch C:\Code\python\Modules\cjkcodecs\_iso2022_jp_2.c(60) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data C:\Code\python\Modules\cjkcodecs\_iso2022_jp_2.c(72) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data C:\Code\python\Modules\cjkcodecs\_iso2022_jp_2.c(88) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data C:\Code\python\Modules\cjkcodecs\_iso2022_jp_2.c(143) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data _iso2022_jp_3.c C:\Code\python\Modules\cjkcodecs\iso2022common.h(189) : warning C4018: '>=' : signed/unsigned mismatch C:\Code\python\Modules\cjkcodecs\iso2022common.h(196) : warning C4018: '<' : signed/unsigned mismatch _iso2022_jp_ext.c C:\Code\python\Modules\cjkcodecs\_iso2022_jp_3.c(84) : warning C4761: integral size mismatch in argument; conversion supplied C:\Code\python\Modules\cjkcodecs\_iso2022_jp_3.c(91) : warning C4761: integral size mismatch in argument; conversion supplied C:\Code\python\Modules\cjkcodecs\_iso2022_jp_3.c(94) : warning C4761: integral size mismatch in argument; conversion supplied C:\Code\python\Modules\cjkcodecs\iso2022common.h(189) : warning C4018: '>=' : signed/unsigned mismatch C:\Code\python\Modules\cjkcodecs\iso2022common.h(196) : warning C4018: '<' : signed/unsigned mismatch C:\Code\python\Modules\cjkcodecs\_iso2022_jp_ext.c(52) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data C:\Code\python\Modules\cjkcodecs\_iso2022_jp_ext.c(64) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data C:\Code\python\Modules\cjkcodecs\_iso2022_jp_ext.c(80) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data C:\Code\python\Modules\cjkcodecs\_iso2022_jp_ext.c(113) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data _iso2022_kr.c C:\Code\python\Modules\cjkcodecs\iso2022common.h(189) : warning C4018: '>=' : signed/unsigned mismatch C:\Code\python\Modules\cjkcodecs\_iso2022_kr.c(46) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data C:\Code\python\Modules\cjkcodecs\_iso2022_kr.c(50) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data _johab.c C:\Code\python\Modules\cjkcodecs\_johab.c(47) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data _shift_jis.c C:\Code\python\Modules\cjkcodecs\_shift_jis.c(35) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data _shift_jisx0213.c C:\Code\python\Modules\cjkcodecs\_shift_jisx0213.c(36) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data mapdata_ja_JP.c C:\Code\python\Modules\cjkcodecs\_shift_jisx0213.c(51) : warning C4761: integral size mismatch in argument; conversion supplied C:\Code\python\Modules\cjkcodecs\_shift_jisx0213.c(58) : warning C4761: integral size mismatch in argument; conversion supplied C:\Code\python\Modules\cjkcodecs\_shift_jisx0213.c(61) : warning C4761: integral size mismatch in argument; conversion supplied mapdata_ko_KR.c mapdata_zh_CN.c mapdata_zh_TW.c _big5.c C:\Code\python\Modules\cjkcodecs\_big5.c(21) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data

On Thu, Jan 22, 2004 at 02:20:15PM -0500, Tim Peters wrote:
Under MSVC 6, tons of new warnings are generated for these new files. Then all the new tests fail on Win98SE, with errors like:
LookupError: unknown encoding: shift_jisx0213
New warnings:
multibytecodec.c _cp932.c C:\Code\python\Modules\cjkcodecs\_cp932.c(23) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data [snip]
Okay. It's fixed in CVS. If you find another warnings not fixed by this, please let me know. BTW, I got a traceback on committing. (maybe from a cvsmail script?) Checking in _big5.c; /cvsroot/python/python/dist/src/Modules/cjkcodecs/_big5.c,v <-- _big5.c new revision: 1.2; previous revision: 1.1 done Checking in _cp932.c; [snip] new revision: 1.2; previous revision: 1.1 done Traceback (most recent call last): File "/cvsroot/python/CVSROOT/syncmail", line 329, in ? main() File "/cvsroot/python/CVSROOT/syncmail", line 322, in main blast_mail(subject, people, specs[1:], contextlines, fromhost) File "/cvsroot/python/CVSROOT/syncmail", line 224, in blast_mail conn.connect(MAILHOST, MAILPORT) File "/usr/lib/python2.2/smtplib.py", line 276, in connect for res in socket.getaddrinfo(host, port, 0, socket.SOCK_STREAM): socket.gaierror: (-2, 'Name or service not known') Hye-Shik

On Fri, 2004-01-23 at 09:42, Hye-Shik Chang wrote:
BTW, I got a traceback on committing. (maybe from a cvsmail script?)
I recently got a message from SF saying they upgraded the Python on the cvs machine to 2.2.3. I'm wondering if they also turned off smtp on that machine (syncmail's MAILHOST variable points to localhost via its empty string value). I've seen this same error, or reports of this on several projects and have a message into SF to find out what's up. -Barry

Barry Warsaw <barry@python.org> writes:
I recently got a message from SF saying they upgraded the Python on the cvs machine to 2.2.3. I'm wondering if they also turned off smtp on that machine (syncmail's MAILHOST variable points to localhost via its empty string value). I've seen this same error, or reports of this on several projects and have a message into SF to find out what's up.
Hm, no checkin messages yesterday, but I see Fred just got one through 10:30 EST so maybe its OK now. -- KBK

Kurt B. Kaiser writes:
Hm, no checkin messages yesterday, but I see Fred just got one through 10:30 EST so maybe its OK now.
SourceForge changed some of their mail configuration, and we just worked out the fix. My commit this morning was really to test that it actually worked. ;-) -Fred -- Fred L. Drake, Jr. <fdrake at acm.org> PythonLabs at Zope Corporation

On Fri, 2004-01-23 at 11:00, Kurt B. Kaiser wrote:
Barry Warsaw <barry@python.org> writes:
I recently got a message from SF saying they upgraded the Python on the cvs machine to 2.2.3. I'm wondering if they also turned off smtp on that machine (syncmail's MAILHOST variable points to localhost via its empty string value). I've seen this same error, or reports of this on several projects and have a message into SF to find out what's up.
Hm, no checkin messages yesterday, but I see Fred just got one through 10:30 EST so maybe its OK now.
We just fixed it. -Barry

[Barry]
I recently got a message from SF saying they upgraded the Python on the cvs machine to 2.2.3. I'm wondering if they also turned off smtp on that machine (syncmail's MAILHOST variable points to localhost via its empty string value). I've seen this same error, or reports of this on several projects and have a message into SF to find out what's up.
I bet this recent blurb on SF's site status page is relevant: (2004-01-23 06:31:27 - Project CVS Service) Due to the recent OS upgrade on the SourceForge.net developer CVS server, it will be necessary for any per-project syncmail script installations to make a one-line change to their syncmail script. The central copy of the syncmail script which is used by a number of projects has already been modified in this manner. To function properly, the MAILHOST line should be hardcoded to MAILHOST = 'localhost'. Additional information on syncmail may be found in Enhancing Project CVS Services Using Scripts; the SourceForge.net team maintains a central copy of the syncmail script which your project may use. So did they upgrade to Windows <wink>? Having to say 'localhost' instead of using an empty string is universal across Windows flavors.

Kurt B. Kaiser writes:
Thanks! Hopefully they will email admins.
heading off to fix IDLEfork syncmail....
I've sent a note to the cvs-syncmail-talk list, but I haven't seen it show up in my mailbox yet. lists.sourceforge.net seems to be *really* slow right now. ;-( -Fred -- Fred L. Drake, Jr. <fdrake at acm.org> PythonLabs at Zope Corporation

On Fri, 2004-01-23 at 12:06, Fred L. Drake, Jr. wrote:
Kurt B. Kaiser writes:
Thanks! Hopefully they will email admins.
heading off to fix IDLEfork syncmail....
I've sent a note to the cvs-syncmail-talk list, but I haven't seen it show up in my mailbox yet. lists.sourceforge.net seems to be *really* slow right now. ;-(
Along with everything else on SF. :/ -Barry

[Hye-Shik Chang, on compiler warnings in cjkcodecs]
Okay. It's fixed in CVS. If you find another warnings not fixed by this, please let me know.
I wasn't able to get the new files from SourceForge before tonight, and all the warnings under MSVC6 went away when I finally got them. Even better <wink>, these tests pass now. Thank you!
participants (5)
-
Barry Warsaw
-
Fred L. Drake, Jr.
-
Hye-Shik Chang
-
kbk@shore.net
-
Tim Peters