Hi,
I thought that patches that clean up code but don’t fix actual bugs were not done in stable branches. Has this changed? (The first commit quoted above may be a performance fix, which would be okay IIRC.) Regards
Removing dead code and bypassing redundant code are both reasonable bug fixes. The kind of change to be avoided is gratuitous replacement of older idioms with newer ones. -- Nick Coghlan (via Gmail on Android, so likely to be more terse than usual)
On Oct 31, 2011, at 06:23 PM, Éric Araujo wrote:
I thought that patches that clean up code but don’t fix actual bugs were not done in stable branches. Has this changed?
I hope not. Sure, if they fix actual bugs, that's fine, but as MvL often points out, even innocent looking changes can break code *somewhere*. We don't lose by being conservative with our stable branches. -Barry
Nick and Brett share the opinion that some code cleanups can be considered bugfixes, whereas MvL, Barry and Raymond defend that we never know what can get broken and it’s not worth risking it. I have added a comment on #13283 (removal of two unused variable in locale.py) to restate this policy, but haven’t asked for a revert; I did not comment on #10519 (Avoid unnecessary recursive function calls), as it can be considered a bugfix and Raymond took part in the discussion and thus implicitly approved the change. Regards
On Sat, Nov 5, 2011 at 3:05 AM, Éric Araujo <merwok@netwok.org> wrote:
There's always going to be a grey area where it's a judgment call - my opinion is basically the same as what you state in your second paragraph. Cheers, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
Removing dead code and bypassing redundant code are both reasonable bug fixes. The kind of change to be avoided is gratuitous replacement of older idioms with newer ones. -- Nick Coghlan (via Gmail on Android, so likely to be more terse than usual)
On Oct 31, 2011, at 06:23 PM, Éric Araujo wrote:
I thought that patches that clean up code but don’t fix actual bugs were not done in stable branches. Has this changed?
I hope not. Sure, if they fix actual bugs, that's fine, but as MvL often points out, even innocent looking changes can break code *somewhere*. We don't lose by being conservative with our stable branches. -Barry
Nick and Brett share the opinion that some code cleanups can be considered bugfixes, whereas MvL, Barry and Raymond defend that we never know what can get broken and it’s not worth risking it. I have added a comment on #13283 (removal of two unused variable in locale.py) to restate this policy, but haven’t asked for a revert; I did not comment on #10519 (Avoid unnecessary recursive function calls), as it can be considered a bugfix and Raymond took part in the discussion and thus implicitly approved the change. Regards
On Sat, Nov 5, 2011 at 3:05 AM, Éric Araujo <merwok@netwok.org> wrote:
There's always going to be a grey area where it's a judgment call - my opinion is basically the same as what you state in your second paragraph. Cheers, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
participants (5)
-
Barry Warsaw -
Brett Cannon -
Nick Coghlan -
Raymond Hettinger -
Éric Araujo