One more cherry-pick request for 3.4.0 that I'd like a little public debate on
Victor has asked me to cherry-pick 180e4b678003: http://bugs.python.org/issue20320 (original issue) http://hg.python.org/cpython/rev/180e4b678003/ (checkin into trunk) http://bugs.python.org/issue20646 (cherry-pick request) This revision changes the rounding behavior of fractional-second timeouts for select.select and select.kqueue. I don't have enough context to judge whether or not this is bad enough to warrant cherry-picking, and the discussion on the issue didn't seem to come to a firm consensus. Can I get some opinions on this? FWIW, I'm going to cut the next preview in a few minutes, and this won't be in it, but I don't actually tag until most of a day from now. //arry/
On Sat, 22 Feb 2014 01:42:57 -0600
Larry Hastings
Victor has asked me to cherry-pick 180e4b678003:
http://bugs.python.org/issue20320 (original issue) http://hg.python.org/cpython/rev/180e4b678003/ (checkin into trunk) http://bugs.python.org/issue20646 (cherry-pick request)
This revision changes the rounding behavior of fractional-second timeouts for select.select and select.kqueue. I don't have enough context to judge whether or not this is bad enough to warrant cherry-picking, and the discussion on the issue didn't seem to come to a firm consensus.
Can I get some opinions on this?
Well, it's certainly not rc-critical. It improves a bit a fringe behaviour that's unlikely to be noticeable by anyone in the real world. If you look at http://bugs.python.org/issue20320, Charles-François there explains why it's a minor issue. Regards Antoine.
On 02/22/2014 03:27 AM, Antoine Pitrou wrote:
On Sat, 22 Feb 2014 01:42:57 -0600 Larry Hastings
wrote: Victor has asked me to cherry-pick 180e4b678003:
http://bugs.python.org/issue20320 (original issue) http://hg.python.org/cpython/rev/180e4b678003/ (checkin into trunk) http://bugs.python.org/issue20646 (cherry-pick request)
This revision changes the rounding behavior of fractional-second timeouts for select.select and select.kqueue. I don't have enough context to judge whether or not this is bad enough to warrant cherry-picking, and the discussion on the issue didn't seem to come to a firm consensus.
Can I get some opinions on this? Well, it's certainly not rc-critical. It improves a bit a fringe behaviour that's unlikely to be noticeable by anyone in the real world.
If you look at http://bugs.python.org/issue20320, Charles-François there explains why it's a minor issue.
Yes, I read the reply by Charles-François. I was interested in seeing more opinions. However, nobody seems to be stepping up with any, so I'll assume for now it can be left unpicked. //arry/
participants (2)
-
Antoine Pitrou
-
Larry Hastings