issue #15038 - Optimize python Locks on Windows
Hi, Could I get some feedback on this proposed patch? It would be great to get it in before the beta. Cheers, Kristján
On Tue, 12 Jun 2012 11:23:28 +0000
Kristján Valur Jónsson
Hi, Could I get some feedback on this proposed patch? It would be great to get it in before the beta.
The review I made on your previous patch still applies. You shouldn't ask for feedback if you aren't willing to take it into account... Regards Antoine.
I have reworked the patch, so it might be helpful to specify what exactly it is that you object to. Perhaps in the defect itself. I can add here that your worries that the previous patch defaulted to Vista specific features, were actually unfounded. I've added my reasons for including vista specific support in in with the issue as well. I happen to think it is a good idea and would like to get the input from others on that particular issue. Cheers, K
-----Original Message----- From: python-dev-bounces+kristjan=ccpgames.com@python.org [mailto:python-dev-bounces+kristjan=ccpgames.com@python.org] On Behalf Of Antoine Pitrou Sent: 13. júní 2012 00:26 To: python-dev@python.org Subject: Re: [Python-Dev] issue #15038 - Optimize python Locks on Windows
The review I made on your previous patch still applies. You shouldn't ask for feedback if you aren't willing to take it into account...
Regards
Antoine.
_______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python- dev/kristjan%40ccpgames.com
On Wed, 13 Jun 2012 13:47:28 +0000
Kristján Valur Jónsson
I have reworked the patch, so it might be helpful to specify what exactly it is that you object to. Perhaps in the defect itself. I can add here that your worries that the previous patch defaulted to Vista specific features, were actually unfounded.
Ok, thanks. I probably have misunderstood the chain of #define's. I will let other people comment on the other aspects of the patch. Regards Antoine.
participants (2)
-
Antoine Pitrou
-
Kristján Valur Jónsson