internal weakref API should be Py_ssize_t?
I'm wondering if the following change should be made to Include/weakrefobject.h: -PyAPI_FUNC(long) _PyWeakref_GetWeakrefCount(PyWeakReference *head); +PyAPI_FUNC(Py_ssize_t) _PyWeakref_GetWeakrefCount(PyWeakReference *head); And the 2 other files which use this (weakref obj and module). Should this be changed now, wait for 2.6, or not worry about it? n
[Neal Norwitz]
I'm wondering if the following change should be made to Include/weakrefobject.h:
Yes.
-PyAPI_FUNC(long) _PyWeakref_GetWeakrefCount(PyWeakReference *head); +PyAPI_FUNC(Py_ssize_t) _PyWeakref_GetWeakrefCount(PyWeakReference *head);
And the 2 other files which use this (weakref obj and module). Should this be changed now, wait for 2.6, or not worry about it?
+1 on biting the bullet for 2.5.
Neal Norwitz wrote:
I'm wondering if the following change should be made to Include/weakrefobject.h:
On Wednesday 02 August 2006 00:53, Tim Peters wrote:
Yes. ... +1 on biting the bullet for 2.5.
Agreed. This should definately go with the rest of the Py_ssize_t changes. -Fred -- Fred L. Drake, Jr. <fdrake at acm.org>
participants (3)
-
Fred L. Drake, Jr. -
Neal Norwitz -
Tim Peters