Re: [Python-Dev] [Python-checkins] cpython: Remove mention of medical condition from the test suite.
If you're going to get rid of the pun, you might as well change the whole sentence... On Sun, Jul 3, 2011 at 1:22 PM, georg.brandl <python-checkins@python.org> wrote:
http://hg.python.org/cpython/rev/76452b892838 changeset: 71146:76452b892838 parent: 71144:ce52310f61a0 user: Georg Brandl <georg@python.org> date: Sun Jul 03 19:22:42 2011 +0200 summary: Remove mention of medical condition from the test suite.
files: Lib/test/test_csv.py | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/Lib/test/test_csv.py b/Lib/test/test_csv.py --- a/Lib/test/test_csv.py +++ b/Lib/test/test_csv.py @@ -459,20 +459,20 @@ '5', '6']])
def test_quoted_quote(self): - self.readerAssertEqual('1,2,3,"""I see,"" said the blind man","as he picked up his hammer and saw"', + self.readerAssertEqual('1,2,3,"""I see,"" said the happy man","as he picked up his hammer and saw"', [['1', '2', '3', - '"I see," said the blind man', + '"I see," said the happy man', 'as he picked up his hammer and saw']])
def test_quoted_nl(self): input = '''\ 1,2,3,"""I see,"" -said the blind man","as he picked up his +said the happy man","as he picked up his hammer and saw" 9,8,7,6''' self.readerAssertEqual(input, [['1', '2', '3', - '"I see,"\nsaid the blind man', + '"I see,"\nsaid the happy man', 'as he picked up his\nhammer and saw'], ['9','8','7','6']])
-- Repository URL: http://hg.python.org/cpython
_______________________________________________ Python-checkins mailing list Python-checkins@python.org http://mail.python.org/mailman/listinfo/python-checkins
Jim Jewett writes:
If you're going to get rid of the pun, you might as well change the whole sentence...
In fact, he should, since this is such a well-known pun that many people will consciously make the reverse substitution, and wonder WTF python-dev was thinking when they put the amended sentence in the test. Maybe somebody was *trying* to offend people who make such corrections habitually by demonstrating the kind of nonsense they occasionally produce. I've seen that target hit several times. Also, the log should say why this was done. - Remove mention of medical condition from the test suite. + Change potentially offensive language in the test suite. One could also use the somewhat euphemistic "unprofessional language". That points to why such changes are justified despite an author's right to have her mode of expression respected -- the Python project aims at professionalism, and offensive language detracts from it.
On Tue, 05 Jul 2011 15:27:00 +0900 "Stephen J. Turnbull" <stephen@xemacs.org> wrote:
One could also use the somewhat euphemistic "unprofessional language". That points to why such changes are justified despite an author's right to have her mode of expression respected -- the Python project aims at professionalism, and offensive language detracts from it.
I sincerely hope we don't start using the word "professional" to denote "careful" or "good quality". Most professional work is crap, and that's why we have open source. Regards Antoine.
Antoine Pitrou writes:
I sincerely hope we don't start using the word "professional" to denote "careful" or "good quality".
No, by "professional" I mean "of a profession," which is a service that is provided by experts to laymen, and therefore demands adherence to certain standards since the clients are not able to judge the product for themselves, but in general must trust the vendor. The care and good quality proceed from the commitment of the professional.
Most professional work is crap, and that's why we have open source.
Open source is not a substitute for professionalism.
On Wed, 06 Jul 2011 01:23:55 +0900 "Stephen J. Turnbull" <stephen@xemacs.org> wrote:
Antoine Pitrou writes:
I sincerely hope we don't start using the word "professional" to denote "careful" or "good quality".
No, by "professional" I mean "of a profession," which is a service that is provided by experts to laymen, and therefore demands adherence to certain standards since the clients are not able to judge the product for themselves, but in general must trust the vendor. The care and good quality proceed from the commitment of the professional.
I see. But the "experts" are not necessarily vendors (we aren't), and our users aren't "clients". Besides, we are not merely providing a service, we are building a community where everyone can take part in the shared work, thereby blurring the barrier between "experts" and "laymen". Regards Antoine.
Antoine Pitrou writes:
On Wed, 06 Jul 2011 01:23:55 +0900 "Stephen J. Turnbull" <stephen@xemacs.org> wrote:
Antoine Pitrou writes:
I sincerely hope we don't start using the word "professional" to denote "careful" or "good quality".
No, by "professional" I mean "of a profession,"
I see. But the "experts" are not necessarily vendors (we aren't), and our users aren't "clients". Besides, we are not merely providing a service, we are building a community where everyone can take part in the shared work, thereby blurring the barrier between "experts" and "laymen".
*sigh* And another good word bites the dust. OK, I will reserve the adjective "professional" for those who appreciate it. Nick's "common courtesy" will do for the current purpose.
On Tue, Jul 5, 2011 at 4:27 PM, Stephen J. Turnbull <stephen@xemacs.org> wrote:
That points to why such changes are justified despite an author's right to have her mode of expression respected -- the Python project aims at professionalism, and offensive language detracts from it.
Given that the contents of many test strings are quite arbitrary, I personally consider a bit of inoffensive humour or cultural references to be a fine thing to include rather than yet another instance of "foobar" (which itself has humorous *and* offensive origins). Heck, stripping just the Monty Python quotes from the test suite would probably take a while :) Avoiding offensive text has nothing to do with a desire to appear "professional" (at least for me) - it's about demonstrating common courtesy to the potentially wide variety of people that will read the Python source code in the future. (In the specific case, I thought quoting the venerable pun was fine, but I also don't have any real problem with modifying it) Cheers, Nick. P.S. 'twas a sad day when copyright concerns cost us the old test audio file :( -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
participants (4)
-
Antoine Pitrou -
Jim Jewett -
Nick Coghlan -
Stephen J. Turnbull