should I check in this test_xmlrpc test case change?
When I made the latest change to xmlrpclib.py (to test for integer overflow), I also expanded the test_xmlrpc.py file. Unfortunately, I forgot to check it in. Should I do that now or file it as a separate patch? Skip
When I made the latest change to xmlrpclib.py (to test for integer overflow), I also expanded the test_xmlrpc.py file. Unfortunately, I forgot to check it in. Should I do that now or file it as a separate patch?
Assuming that it works for you :-), check it in to the trunk. It won't make it into 2.2b1, but it will be ready for 2.2b2. --Guido van Rossum (home page: http://www.python.org/~guido/)
"SM" == Skip Montanaro <skip@pobox.com> writes:
SM> When I made the latest change to xmlrpclib.py (to test for SM> integer overflow), I also expanded the test_xmlrpc.py file. SM> Unfortunately, I forgot to check it in. Should I do that now SM> or file it as a separate patch? You can check it into the trunk, but it's too late for anything else to make it in 2.2b1 now. -Barry
BAW> You can check it into the trunk, but it's too late for anything BAW> else to make it in 2.2b1 now. Thanks, will do. I didn't care about making 2.2b1 (it is just a test case, after all). I just didn't want to botch something up related to the mechanics of the release. Skip
"SM" == Skip Montanaro <skip@pobox.com> writes:
BAW> You can check it into the trunk, but it's too late for BAW> anything else to make it in 2.2b1 now. SM> Thanks, will do. I didn't care about making 2.2b1 (it is just SM> a test case, after all). I just didn't want to botch SM> something up related to the mechanics of the release. The trunk is always safe to make commits to. That's why we release from a branch. -Barry
participants (3)
-
barry＠zope.com -
Guido van Rossum -
Skip Montanaro