Handling PR branches in "make patchcheck"

Hi folks, With the move to a PR based workflow, I've been finding "make patchcheck" less helpful than it used to be, as it was only checking the changes that had yet to be committed at all, and ignoring those that had already been checked in on the PR branch. I've put together a proposed update to Tools/scripts/patchcheck.py that makes it aware of git branches, and automatically diffs against the base branch when it detects something that "looks like" a PR branch: http://bugs.python.org/issue29656 I can vouch for it working in my particular setup (where "origin" refers to the upstream repo), but it would be good if folks could try it out with other configurations before we merge it (in particular, it *should* handle the case where the upstream remote is called "upstream", but I don't use that arrangement myself). Cheers, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
participants (1)
-
Nick Coghlan