Re: [Python-Dev] [Python-checkins] cpython: don't depend on __debug__ because it's baked in at freeze time (issue #16046)
On Wed, Sep 26, 2012 at 1:23 AM, benjamin.peterson <python-checkins@python.org> wrote:
If debug_override is not None, then it must be a boolean and is taken as - the value of __debug__ instead. + the value of bool(sys.flags.optimize) instead.
s/bool(sys.flags.optimize)/"not sys.flags.optimize"/? It may be better to just rephrase this sentence entirely to better account for the fact that we're now checking the runtime sys.flags.optimize value rather than the compile time __debug__ value. Cheers, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
2012/9/25 Nick Coghlan <ncoghlan@gmail.com>:
On Wed, Sep 26, 2012 at 1:23 AM, benjamin.peterson <python-checkins@python.org> wrote:
If debug_override is not None, then it must be a boolean and is taken as - the value of __debug__ instead. + the value of bool(sys.flags.optimize) instead.
s/bool(sys.flags.optimize)/"not sys.flags.optimize"/?
It may be better to just rephrase this sentence entirely to better account for the fact that we're now checking the runtime sys.flags.optimize value rather than the compile time __debug__ value.
Good point; I rephrased it. -- Regards, Benjamin
participants (2)
-
Benjamin Peterson -
Nick Coghlan