Re: [Python-Dev] [Python-checkins] r86750 - python/branches/py3k/Demo/curses/life.py
Hello,
Author: senthil.kumaran Log: Mouse support and colour to Demo/curses/life.py by Dafydd Crosby
Modified: python/branches/py3k/Demo/curses/life.py Okay, this time I’m reacting to the right branch <wink>
Modified: python/branches/py3k/Demo/curses/life.py ============================================================================== --- python/branches/py3k/Demo/curses/life.py (original) +++ python/branches/py3k/Demo/curses/life.py Thu Nov 25 15:56:44 2010 @@ -1,6 +1,7 @@ #!/usr/bin/env python3 # life.py -- A curses-based version of Conway's Game of Life. # Contributed by AMK +# Mouse support and colour by Dafydd Crosby Shouldn’t his name rather be in Misc/ACKS too? Modules typically (warning: non-scientific data) include the name of the author or first contributors but not the name of every contributor.
I think these cool features deserve a note in Misc/NEWS too :) Re: “colour”: the rest of the file use US English, as do the function names (see for example curses.has_color). It’s good to use one dialect consistently in one file. going-back-to-stare-at-shiny-colors-ly yours, Éric
On Fri, Nov 26, 2010 at 02:32:43AM +0100, Éric Araujo wrote:
Shouldn’t his name rather be in Misc/ACKS too? Modules typically (warning: non-scientific data) include the name of the author or first contributors but not the name of every contributor.
I think these cool features deserve a note in Misc/NEWS too :)
I don't think it is required. Demo stuffs are usually fun demonstrations. The contributor had added his name to patch in the header, and I just left it like that. It's fine. For features and important patches (subjective), Misc/{ACKS,NEWS} are both added.
Re: “colour”: the rest of the file use US English, as do the function names (see for example curses.has_color). It’s good to use one dialect consistently in one file.
Good catch. Did not realize it because, we write it as colour too. Changing it. Thanks, Senthil
On Fri, Nov 26, 2010 at 12:15 PM, Senthil Kumaran <orsenthil@gmail.com> wrote:
Re: “colour”: the rest of the file use US English, as do the function names (see for example curses.has_color). It’s good to use one dialect consistently in one file.
Good catch. Did not realize it because, we write it as colour too. Changing it.
I just resign myself to having to spell words like colour and serialise wrong when I'm working on Python. Compared to the adjustments the non-native English speakers have to make, I figure I'm getting off lightly ;) Cheers, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
On 27/11/2010 12:22, Nick Coghlan wrote:
On Fri, Nov 26, 2010 at 12:15 PM, Senthil Kumaran<orsenthil@gmail.com> wrote:
Re: “colour”: the rest of the file use US English, as do the function names (see for example curses.has_color). It’s good to use one dialect consistently in one file. Good catch. Did not realize it because, we write it as colour too. Changing it. I just resign myself to having to spell words like colour and serialise wrong when I'm working on Python. Compared to the adjustments the non-native English speakers have to make, I figure I'm getting off lightly ;)
I *thought* that the Python policy was that English speakers wrote documentation in English and American speakers wrote documentation in American and that we *don't* insist on US spellings in the Python documentation? Michael
Cheers, Nick.
-- http://www.voidspace.org.uk/ READ CAREFULLY. By accepting and reading this email you agree, on behalf of your employer, to release me from all obligations and waivers arising from any and all NON-NEGOTIATED agreements, licenses, terms-of-service, shrinkwrap, clickwrap, browsewrap, confidentiality, non-disclosure, non-compete and acceptable use policies (”BOGUS AGREEMENTS”) that I have entered into with your employer, its partners, licensors, agents and assigns, in perpetuity, without prejudice to my ongoing rights and privileges. You further represent that you have the authority to release me from any BOGUS AGREEMENTS on behalf of your employer.
On Sat, Nov 27, 2010 at 10:52 PM, Michael Foord <fuzzyman@voidspace.org.uk> wrote:
I just resign myself to having to spell words like colour and serialise wrong when I'm working on Python. Compared to the adjustments the non-native English speakers have to make, I figure I'm getting off lightly ;)
I *thought* that the Python policy was that English speakers wrote documentation in English and American speakers wrote documentation in American and that we *don't* insist on US spellings in the Python documentation?
If we're just talking about those things in generally, then that's a reasonable rule. But when in close proximity to an actual API that uses the American spelling, or modifying a file that uses the relevant word a lot, following the prevailing style is a definite courtesy to the reader. Cheers, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
On 27/11/2010 15:04, Nick Coghlan wrote:
I just resign myself to having to spell words like colour and serialise wrong when I'm working on Python. Compared to the adjustments the non-native English speakers have to make, I figure I'm getting off lightly ;)
I *thought* that the Python policy was that English speakers wrote documentation in English and American speakers wrote documentation in American and that we *don't* insist on US spellings in the Python documentation? If we're just talking about those things in generally, then that's a reasonable rule. But when in close proximity to an actual API that uses the American spelling, or modifying a file that uses the relevant word a lot, following the prevailing style is a definite courtesy to
On Sat, Nov 27, 2010 at 10:52 PM, Michael Foord <fuzzyman@voidspace.org.uk> wrote: the reader.
Ok, thanks. Sounds like a good guideline. Michael
Cheers, Nick.
-- http://www.voidspace.org.uk/ READ CAREFULLY. By accepting and reading this email you agree, on behalf of your employer, to release me from all obligations and waivers arising from any and all NON-NEGOTIATED agreements, licenses, terms-of-service, shrinkwrap, clickwrap, browsewrap, confidentiality, non-disclosure, non-compete and acceptable use policies (”BOGUS AGREEMENTS”) that I have entered into with your employer, its partners, licensors, agents and assigns, in perpetuity, without prejudice to my ongoing rights and privileges. You further represent that you have the authority to release me from any BOGUS AGREEMENTS on behalf of your employer.
participants (4)
-
Michael Foord -
Nick Coghlan -
Senthil Kumaran -
Éric Araujo