OS/2 VAC++ patches
I have looked at Michael Muller's VAC++ patches, and added comments as followups. In summary: 473749 - has several (minor IMO) stylistic issues (addition of OS/2 #ifdefs). The intent of the changes looks OK, as do most of the actual changes (those in OS/2 VAC specific files or existing OS/2 #ifdefs). 474169 - looks good to go (changes inside existing OS/2 #ifdef) 474500 - looks good to go (isolated to OS/2 specific file) Comments on the stylistic issues? -- Andrew I MacIntyre "These thoughts are mine alone..." E-mail: andymac@bullseye.apana.org.au | Snail: PO Box 370 andymac@pcug.org.au | Belconnen ACT 2616 Web: http://www.andymac.org/ | Australia
On Tue, 30 Oct 2001, Andrew MacIntyre wrote:
473749 - has several (minor IMO) stylistic issues (addition of OS/2 #ifdefs). The intent of the changes looks OK, as do most of the actual changes (those in OS/2 VAC specific files or existing OS/2 #ifdefs).
Michael has uploaded a revised patch addressing the stylistic points noted.
474169 - looks good to go (changes inside existing OS/2 #ifdef) 474500 - looks good to go (isolated to OS/2 specific file)
474500 has been committed (thanks Tim!). If possible I'd like to see both 473749 (the updated version) and 474169 make it into 2.2b2, to give 2.2 a chance to ship with the OS/2 VAC++ port buildable from the release sourceball (the EMX port won't make it into CVS for 2.2). Is someone (Tim?) prepared to consider committing these before 2.2b2 branches? Is there anything more I or Michael can do to make this happen? (as previously advised, I'm not going to be in a position to take on CVS commits until after 2.2b2) -- Andrew I MacIntyre "These thoughts are mine alone..." E-mail: andymac@bullseye.apana.org.au | Snail: PO Box 370 andymac@pcug.org.au | Belconnen ACT 2616 Web: http://www.andymac.org/ | Australia
[Andrew MacIntyre]
... If possible I'd like to see both 473749 (the updated version)
I just now checked that in.
and 474169
I believe Martin checked that in previously.
make it into 2.2b2, to give 2.2 a chance to ship with the OS/2 VAC++ port buildable from the release sourceball (the EMX port won't make it into CVS for 2.2).
That's all the OS/2 patches I know about, except for your EMX patches.
... (as previously advised, I'm not going to be in a position to take on CVS commits until after 2.2b2)
In that case we'll release 2.2b2 later tonight <wink>. Thanks for the patches!
participants (2)
-
Andrew MacIntyre -
Tim Peters