Re: [Python-Dev] [Python-checkins] r83885 - in python/branches/py3k: Lib/re.py Lib/test/test_re.py Misc/NEWS
On Mon, Aug 9, 2010 at 8:47 PM, antoine.pitrou <python-checkins@python.org> wrote:
Author: antoine.pitrou Date: Mon Aug 9 12:47:46 2010 New Revision: 83885
Log: Revert r83877 in order to fix compilation
Is this still a problem even after the later checkins to fix the circular build dependency by adding _collections to the static part of the build? Cheers, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
On Mon, Aug 09, 2010 at 10:16:24PM +1000, Nick Coghlan wrote:
On Mon, Aug 9, 2010 at 8:47 PM, antoine.pitrou
Log: Revert r83877 in order to fix compilation
Is this still a problem even after the later checkins to fix the circular build dependency by adding _collections to the static part of the build?
The buildbot page said this: Modules/Setup.dist is newer than Modules/Setup; check to make sure you have all the updates you need in your Modules/Setup file. Usually, copying Modules/Setup.dist to Modules/Setup will work. Do you know what needs to done for making Modules/Setup to reflect the changes in Modules/Setup.dist in the buildbots? On local checkouts, the compilation goes fine. -- Senthil We all agree on the necessity of compromise. We just can't agree on when it's necessary to compromise. -- Larry Wall
On Mon, Aug 9, 2010 at 10:25 PM, Senthil Kumaran <orsenthil@gmail.com> wrote:
Do you know what needs to done for making Modules/Setup to reflect the changes in Modules/Setup.dist in the buildbots? On local checkouts, the compilation goes fine.
The buildbot checkout scripts should probably do that copy as a matter of course. There's no reason to support local modifications of Modules/Setup on the buildbots. Cheers, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
On Mon, 9 Aug 2010 22:34:18 +1000 Nick Coghlan <ncoghlan@gmail.com> wrote:
On Mon, Aug 9, 2010 at 10:25 PM, Senthil Kumaran <orsenthil@gmail.com> wrote:
Do you know what needs to done for making Modules/Setup to reflect the changes in Modules/Setup.dist in the buildbots? On local checkouts, the compilation goes fine.
The buildbot checkout scripts should probably do that copy as a matter of course. There's no reason to support local modifications of Modules/Setup on the buildbots.
Florent found out that removing Modules/Setup is done as part of the "clean" stage: http://www.python.org/dev/buildbot/builders/i386%20Ubuntu%203.x/builds/1820/... but the "clean" stage doesn't get run after a compile error: http://www.python.org/dev/buildbot/waterfall?show=x86%20gentoo%203.x Regards Antoine.
On Mon, Aug 9, 2010 at 10:46 PM, Antoine Pitrou <solipsis@pitrou.net> wrote:
On Mon, 9 Aug 2010 22:34:18 +1000 Nick Coghlan <ncoghlan@gmail.com> wrote:
On Mon, Aug 9, 2010 at 10:25 PM, Senthil Kumaran <orsenthil@gmail.com> wrote:
Do you know what needs to done for making Modules/Setup to reflect the changes in Modules/Setup.dist in the buildbots? On local checkouts, the compilation goes fine.
The buildbot checkout scripts should probably do that copy as a matter of course. There's no reason to support local modifications of Modules/Setup on the buildbots.
Florent found out that removing Modules/Setup is done as part of the "clean" stage: http://www.python.org/dev/buildbot/builders/i386%20Ubuntu%203.x/builds/1820/... but the "clean" stage doesn't get run after a compile error: http://www.python.org/dev/buildbot/waterfall?show=x86%20gentoo%203.x
In that case, once you get a clean run through on the buildbots (with the setup.py changes now in place), you should be OK to check the fnmatch and re changes back in. Longer term, the buildbot setup should be modified to run the cleanup step even if the compilation step fails. I'm assume that is something Martin needs to set up. Cheers, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
On Mon, Aug 9, 2010 at 8:56 AM, Nick Coghlan <ncoghlan@gmail.com> wrote:
Longer term, the buildbot setup should be modified to run the cleanup step even if the compilation step fails.
Running "make clean" after checkout/update should work as well. -Fred -- Fred L. Drake, Jr. <fdrake at gmail.com> "A storm broke loose in my mind." --Albert Einstein
On Mon, 9 Aug 2010 22:16:24 +1000 Nick Coghlan <ncoghlan@gmail.com> wrote:
On Mon, Aug 9, 2010 at 8:47 PM, antoine.pitrou <python-checkins@python.org> wrote:
Author: antoine.pitrou Date: Mon Aug 9 12:47:46 2010 New Revision: 83885
Log: Revert r83877 in order to fix compilation
Is this still a problem even after the later checkins to fix the circular build dependency by adding _collections to the static part of the build?
Yes, it is. Apparently, there is another problem remaining: Traceback (most recent call last): File "./setup.py", line 7, in <module> from glob import glob File "/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/glob.py", line 6, in <module> import fnmatch File "/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/fnmatch.py", line 15, in <module> import functools File "/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/functools.py", line 15, in <module> from collections import OrderedDict, Counter File "/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/collections.py", line 9, in <module> from _collections import deque, defaultdict ImportError: No module named _collections [31908 refs] make: *** [sharedmods] Error 1 http://www.python.org/dev/buildbot/builders/i386%20Ubuntu%203.x/builds/1838/...
participants (4)
-
Antoine Pitrou -
Fred Drake -
Nick Coghlan -
Senthil Kumaran