review request: anti-registration of ABCs
I have unsuccessfully tried to ping the issue http://bugs.python.org/ issue25958 on "anti-registration" of implicit ABCs by setting attributes to None. Guido said: "But with the indicated fixes, I think this good to go (for Python 3.6)" I have manually "rebased" the previous patch by Andrew Barnert taking into account part of the work that has been done on Reversible and fixing final minor comments. I would like this to land in time for 3.6, could someone please review the latest patch and check that everything is OK? -- Ivan
Looking... On Thu, Aug 18, 2016 at 1:16 AM, Ivan Levkivskyi <levkivskyi@gmail.com> wrote:
I have unsuccessfully tried to ping the issue http://bugs.python.org/issue25958 on "anti-registration" of implicit ABCs by setting attributes to None.
Guido said: "But with the indicated fixes, I think this good to go (for Python 3.6)"
I have manually "rebased" the previous patch by Andrew Barnert taking into account part of the work that has been done on Reversible and fixing final minor comments.
I would like this to land in time for 3.6, could someone please review the latest patch and check that everything is OK?
-- Ivan
-- --Guido van Rossum (python.org/~guido)
Committed. Someone please watch the buildbots. On Thu, Aug 18, 2016 at 8:12 AM, Guido van Rossum <guido@python.org> wrote:
Looking...
On Thu, Aug 18, 2016 at 1:16 AM, Ivan Levkivskyi <levkivskyi@gmail.com> wrote:
I have unsuccessfully tried to ping the issue http://bugs.python.org/issue25958 on "anti-registration" of implicit ABCs by setting attributes to None.
Guido said: "But with the indicated fixes, I think this good to go (for Python 3.6)"
I have manually "rebased" the previous patch by Andrew Barnert taking into account part of the work that has been done on Reversible and fixing final minor comments.
I would like this to land in time for 3.6, could someone please review the latest patch and check that everything is OK?
-- Ivan
-- --Guido van Rossum (python.org/~guido)
-- --Guido van Rossum (python.org/~guido)
participants (2)
-
Guido van Rossum
-
Ivan Levkivskyi