As I have time, I'll dig into these. I have a couple of PR already 'out there', which I hope someone will be looking at when/as he/she/they have time. My time will also be intermittent. My next test - and I hope not too difficult - would be the test_utf8. The test: FAIL: test_cmd_line (test.test_utf8_mode.UTF8ModeTests) fails - and I am wondering if it is as simple as AIX default mode is ISO8559-1 and the test looks to be comparing UTF8 with the locale_default. If that is the case, obviously this test will never succeed - asis. Am I understanding the test properly. If yes, then I'll see what I can come up with for a patch to the test for AIX. If no, I'll need some hand holding to help me understand the test A bigger challenge, and I think a major issue with many of the test failures is test_ssl. Here I already know I'll need so assistance. I am quite lost. I know AIX at an expert level, but I do not know python (especially python internals, macros, etc..) and after about 3 levels I am lost. I also find it hard to get 'artifacts' from the tests to know what is expected. Looking forward to assistance from various people - in understanding the tests, and probably better python coding criticism. Michael
Try again on this. a) Victor has said he will look, from time to time - after his vacation. b) our vacations do not overlap c) comment was also made privately, re: my starting a worker for buildbot, that there is not much sense in a bot if noone is working on the tests. I'll do my best, in the (limited) time I have to work on c) - but alone I cannot get anything done. So, Victor suggested I just ask for others to review for now - so I can have some semblance of moving forward - before my vacation starts (about when Victor gets back from his). In advance - many thanks. On 8/5/2018 10:59 PM, Michael wrote:
As I have time, I'll dig into these.
I have a couple of PR already 'out there', which I hope someone will be looking at when/as he/she/they have time. My time will also be intermittent.
My next test - and I hope not too difficult - would be the test_utf8. The test:
FAIL: test_cmd_line (test.test_utf8_mode.UTF8ModeTests) fails - and I am wondering if it is as simple as AIX default mode is ISO8559-1 and the test looks to be comparing UTF8 with the locale_default. If that is the case, obviously this test will never succeed - asis. Am I understanding the test properly. If yes, then I'll see what I can come up with for a patch to the test for AIX. If no, I'll need some hand holding to help me understand the test A bigger challenge, and I think a major issue with many of the test failures is test_ssl. Here I already know I'll need so assistance. I am quite lost. I know AIX at an expert level, but I do not know python (especially python internals, macros, etc..) and after about 3 levels I am lost. I also find it hard to get 'artifacts' from the tests to know what is expected. Looking forward to assistance from various people - in understanding the tests, and probably better python coding criticism. Michael
_______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/aixtools%40felt.demon.nl
On Mon, 6 Aug 2018 at 07:03, Michael
As I have time, I'll dig into these.
I have a couple of PR already 'out there', which I hope someone will be looking at when/as he/she/they have time. My time will also be intermittent.
My next test - and I hope not too difficult - would be the test_utf8. The test:
FAIL: test_cmd_line (test.test_utf8_mode.UTF8ModeTests)
fails - and I am wondering if it is as simple as AIX default mode is ISO8559-1 and the test looks to be comparing UTF8 with the locale_default. If that is the case, obviously this test will never succeed - asis.
Am I understanding the test properly. If yes, then I'll see what I can come up with for a patch to the test for AIX. If no, I'll need some hand holding to help me understand the test
UTF-8 mode relates to PEP 540, and the intent is that the default C/POSIX locale should either be coerced to a UTF-8 based one (by the PEP 538 mechanism), or else UTF-8 mode will activate, and CPython will set its *own* encoding to UTF-8, and ignore the locale one. We did need to make the PEP 538 tests AIX-aware [1] so they knew what to expect as the default encoding when locale coercion was disabled, so it's possible some further special casing will be needed in the UTF-8 mode tests as well. Cheers, Nick. [1] https://github.com/python/cpython/blob/master/Lib/test/test_c_locale_coercio... -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
participants (3)
-
Michael -
Michael Felt
-
Nick Coghlan