On Tue, Mar 26, 2013 at 4:49 PM, Sean Felipe Wolfe wrote:

Hey everybody how are you all :)

I am an intermediate-level python coder looking to get help out. I've been reading over the dev guide about helping increase test coverage --> http://docs.python.org/devguide/coverage.html

And also the third-party code coverage referenced in the devguide page: http://coverage.livinglogic.de/

I'm seeing that according to the coverage tool, two of my favorite libraries, urllib/urllib2, have no unit tests? Is that correct or am I reading it wrong?

If that's correct it seems like a great place perhaps for me to cut my teeth and I would be excited to learn and help out here.

And of course any thoughts or advice for an aspiring Python contributor would be appreciated. Of course the dev guide gives me plenty of good info.

Thanks!

That looks like an error in the coverage report, there are certainly urllib and urllib2 tests in test/test_urllib*

Sean, During the PyCon sprints I was helping work on unittests in urllib. I think as it stands right now urllib/error.py and urllib/parse.py are at 100% line coverage. I have some additions to urllib/request.py which I have yet to submit a patch for (anything above line 700 is covered thus far) and I noticed there is a large chunk of code there which has line coverage when running tests on OSX. There is a note to refactor that to run on all platforms since there is nothing OSX specific in those tests. I believe if those tests were running on all platforms it would drastically increase line coverage for request.py, assuming your not on OSX of coarse. I have not looked at response.py or robotparser.py yet. Just wanted to give you a little brain dump in case it can save you some time. ~Daniel

On Thu, Mar 28, 2013 at 11:36 AM, Walter Dörwald wrote:

Am 27.03.2013 um 03:24 schrieb R. David Murray :

...

On Tue, 26 Mar 2013 16:59:06 -0700, Maciej Fijalkowski wrote:

...

On Tue, Mar 26, 2013 at 4:49 PM, Sean Felipe Wolfe wrote:

...

Hey everybody how are you all :)

I am an intermediate-level python coder looking to get help out. I've been reading over the dev guide about helping increase test coverage --> http://docs.python.org/devguide/coverage.html

And also the third-party code coverage referenced in the devguide page: http://coverage.livinglogic.de/

I'm seeing that according to the coverage tool, two of my favorite libraries, urllib/urllib2, have no unit tests? Is that correct or am I reading it wrong?

If that's correct it seems like a great place perhaps for me to cut my teeth and I would be excited to learn and help out here.

And of course any thoughts or advice for an aspiring Python contributor would be appreciated. Of course the dev guide gives me plenty of good info.

Thanks!

That looks like an error in the coverage report, there are certainly urllib and urllib2 tests in test/test_urllib*

The devguide contains instructions for running coverage yourself, and if I recall correctly the 'fullcoverage' recipe does a better job than what runs at coverage.livinglogic.de.

The job that produces that output has been broken for some time now, and I haven't found the time to look into it. If someone wants to try, here's the code:

https://pypi.python.org/pypi/pycoco/0.7.2

...

[…]

Servus, Walter

Hello Walter and everybody, after a bit of family time and other stuffs, I'm getting back to this today and looking at what's involved in fixing the livinglogic code coverage tool. I was able to get the depencies and a few minor issues, and now the script is running on a first attempt. I'll report back with progress or problems. Thanks y'all :) -- A musician must make music, an artist must paint, a poet must write, if he is to be ultimately at peace with himself. - Abraham Maslow