You don't really have to run the test, just try to import imaplib: C:\Code\python\PCbuild>python Python 2.3a0 (#29, Mar 2 2002, 03:12:05) [MSC 32 bit (Intel)] on win32 Type "help", "copyright", "credits" or "license" for more information.
import imaplib Traceback (most recent call last): File "<stdin>", line 1, in ? File "C:\CODE\PYTHON\lib\imaplib.py", line 986, in ? class IMAP4_SSL(IMAP4): File "C:\CODE\PYTHON\lib\imaplib.py", line 1001, in IMAP4_SSL def __init__(self, host = '', port = IMAP4_SSL_PORT, keyfile = None, certfil e = None): NameError: name 'IMAP4_SSL_PORT' is not defined
Indeed IMAP4_SSL_PORT is not defined, and I don't see how this could be unique to Windows. Aren't people on Linux seeing this too?
Hi! Indeed, IMAP4_SSL_PORT is missing in the checked in version. But it was in my patch, that I've submitted yesterday?! Maybe Piers did the patch just by hand, not by "patch"? It's mainly the missing IMAP4_SSL_PORT and one "," too much in the docstring of IMAP4_SSL_PORT. Increasing of version numer is OK, of course - this I forgot :-) Best regards Tino ----------------- ----------------- These are the differences between my patch and the CVS version at the moment: tino@tinux:~/> diff -c imaplib_tl.py imaplib_cvs.py *** imaplib_tl.py Fri Mar 8 09:04:54 2002 --- imaplib_cvs.py Fri Mar 8 09:03:50 2002 *************** *** 15,23 **** # Authentication code contributed by Donn Cave <donn@u.washington.edu> June 1998. # String method conversion by ESR, February 2001. # GET/SETACL contributed by Anthony Baxter <anthony@interlink.com.au> April 2001. ! # IMAP4_SSL contributed by Tino Lange <tino.lange@isg.de> March 2002 ! __version__ = "2.50" import binascii, re, socket, time, random, sys --- 15,23 ---- # Authentication code contributed by Donn Cave <donn@u.washington.edu> June 1998. # String method conversion by ESR, February 2001. # GET/SETACL contributed by Anthony Baxter <anthony@interlink.com.au> April 2001. ! # IMAP4_SSL contributed by Tino Lange <Tino.Lange@isg.de> March 2002. ! __version__ = "2.51" import binascii, re, socket, time, random, sys *************** *** 29,35 **** CRLF = '\r\n' Debug = 0 IMAP4_PORT = 143 - IMAP4_SSL_PORT = 993 AllowedVersions = ('IMAP4REV1', 'IMAP4') # Most recent first # Commands --- 29,34 ---- *************** *** 983,993 **** n -= 1 class IMAP4_SSL(IMAP4): """IMAP4 client class over SSL connection ! Instantiate with: IMAP4_SSL([host[, port[, keyfile[, certfile]]]]) host - host's name (default: localhost); port - port number (default: standard IMAP4 SSL port). --- 982,993 ---- n -= 1 + class IMAP4_SSL(IMAP4): """IMAP4 client class over SSL connection ! Instantiate with: IMAP4_SSL([, host[, port[, keyfile[, certfile]]]]) host - host's name (default: localhost); port - port number (default: standard IMAP4 SSL port). *************** *** 1052,1057 **** --- 1052,1058 ---- ssl = <instance>.socket.ssl() """ return self.sslobj + class _Authenticator: tino@tinux:~/ >
On Fri, 08 Mar 2002 09:12:26 +0100, Tino Lange wrote:
Hi!
Indeed, IMAP4_SSL_PORT is missing in the checked in version. But it was in my patch, that I've submitted yesterday?! Maybe Piers did the patch just by hand, not by "patch"?
It's mainly the missing IMAP4_SSL_PORT and one "," too much in the docstring of IMAP4_SSL_PORT. Increasing of version numer is OK, of course - this I forgot :-)
Best regards
Tino
My mistake - I had already installed your original imaplib patch, and only installed the libimaplib.tex patch from your new upload. New version now fixed to match the diff below. Incidentally, I can't get into https://sourceforge.net/account/login.php but when i can, i'll update the tracker.
----------------- -----------------
These are the differences between my patch and the CVS version at the moment:
tino@tinux:~/> diff -c imaplib_tl.py imaplib_cvs.py *** imaplib_tl.py Fri Mar 8 09:04:54 2002 --- imaplib_cvs.py Fri Mar 8 09:03:50 2002 *************** *** 15,23 **** # Authentication code contributed by Donn Cave <donn@u.washington.edu> June 1998. # String method conversion by ESR, February 2001. # GET/SETACL contributed by Anthony Baxter <anthony@interlink.com.au> April 2001. ! # IMAP4_SSL contributed by Tino Lange <tino.lange@isg.de> March 2002
! __version__ = "2.50"
import binascii, re, socket, time, random, sys
--- 15,23 ---- # Authentication code contributed by Donn Cave <donn@u.washington.edu> June 1998. # String method conversion by ESR, February 2001. # GET/SETACL contributed by Anthony Baxter <anthony@interlink.com.au> April 2001. ! # IMAP4_SSL contributed by Tino Lange <Tino.Lange@isg.de> March 2002.
! __version__ = "2.51"
import binascii, re, socket, time, random, sys
*************** *** 29,35 **** CRLF = '\r\n' Debug = 0 IMAP4_PORT = 143 - IMAP4_SSL_PORT = 993 AllowedVersions = ('IMAP4REV1', 'IMAP4') # Most recent first
# Commands --- 29,34 ---- *************** *** 983,993 **** n -= 1
class IMAP4_SSL(IMAP4):
"""IMAP4 client class over SSL connection
! Instantiate with: IMAP4_SSL([host[, port[, keyfile[, certfile]]]])
host - host's name (default: localhost); port - port number (default: standard IMAP4 SSL port). --- 982,993 ---- n -= 1
+ class IMAP4_SSL(IMAP4):
"""IMAP4 client class over SSL connection
! Instantiate with: IMAP4_SSL([, host[, port[, keyfile[, certfile]]]])
host - host's name (default: localhost); port - port number (default: standard IMAP4 SSL port). *************** *** 1052,1057 **** --- 1052,1058 ---- ssl = <instance>.socket.ssl() """ return self.sslobj +
class _Authenticator: tino@tinux:~/ >
Tim Peters <tim.one@comcast.net> writes:
Indeed IMAP4_SSL_PORT is not defined, and I don't see how this could be unique to Windows. Aren't people on Linux seeing this too?
I see that, too. Actually, I didn't, because I a) did not update the tree for more than 12 hours, and b) do not normally import imaplib. I guess this is related to revision 1.44 date: 2002/03/08 01:53:24; author: pierslauder; state: Exp; lines: +74 -1 add SSL class submitted by Tino Lange How this passed test_imaplib is a question that only Piers can answer :-) Regards, Martin
participants (4)
-
martin＠v.loewis.de -
Piers Lauder -
Tim Peters -
Tino Lange