bdist_wininst has seen a lot of bug fixes and improvements, mostly by Mark, partly by me. I'd like to 'improve' the visual appearance, too. First, I would like to add an XP style manifest as resource in the exe, which displays the gui elements in the XP style when running under XP. I don't think this will create problems on older windows versions, but if anyone knows better please speak up. Second, the default bitmap it displays is the old Python Powered logo by Just (that with the cool license ;-). A much better bitmap would be that from <http://tinyurl.com/595xd>, which seems to have been made for the PSF. There are two problems with this image: The size is 122x261 pixels, while bdist_wininst would prefer 152x261 pixels. Maybe someone can recreate the icon with a changed size? The file size, when it is converted to 24-bit color bmp, is nearly 100 kB, which is a bit large imo for an optical gimmik - but this can probably be fixed by compressing the image in the installer itself. Finally, I'm not sure I'm allowed to use and redistribute this image. Third, the installer executable doesn't have an icon. Personally I don't care too much about that, but Phil Hornby made two icons which he posted to the distutils list (the gmane archives do a nice job to show the icons on the web page): <http://article.gmane.org/gmane.comp.python.distutils.devel/852> <http://article.gmane.org/gmane.comp.python.distutils.devel/855> Note that with standard Python it is not possible to change the default icon to something else, although it could be done with pywin32, or with some tools included in py2exe. So, distutils bdist_wininst probably can not provide an option to change the icon to something else. Also I know that some people build bdist_wininst installers on Linux, which is possible for pure python package distributions, but it wouldn't be possible to change the icon there anyway. So, the question is: is this icon good enough to have it in basically every distutils' created windows installer? Thomas
Thomas Heller wrote:
bdist_wininst has seen a lot of bug fixes and improvements, mostly by Mark, partly by me.
I'd like to 'improve' the visual appearance, too.
One improvement would be proper treatment of Unicode. Currently it doesn't seem to be possible to use unicode objects with umlauts in the arguments to distutils.core.setup(). Some of my Windows packages say "Author: Walter Dxf6rwald" Bye, Walter Dörwald
Walter Dörwald <walter@livinglogic.de> writes:
Thomas Heller wrote:
bdist_wininst has seen a lot of bug fixes and improvements, mostly by Mark, partly by me. I'd like to 'improve' the visual appearance, too.
One improvement would be proper treatment of Unicode. Currently it doesn't seem to be possible to use unicode objects with umlauts in the arguments to distutils.core.setup(). Some of my Windows packages say "Author: Walter Dxf6rwald"
Can you point me to some of your setup scripts? Thanks, Thomas
Thomas Heller wrote:
Walter Dörwald <walter@livinglogic.de> writes:
Thomas Heller wrote:
bdist_wininst has seen a lot of bug fixes and improvements, mostly by Mark, partly by me. I'd like to 'improve' the visual appearance, too.
One improvement would be proper treatment of Unicode. Currently it doesn't seem to be possible to use unicode objects with umlauts in the arguments to distutils.core.setup(). Some of my Windows packages say "Author: Walter Dxf6rwald"
Can you point me to some of your setup scripts?
http://www.livinglogic.de/viewcvs/index.cgi/LivingLogic/Python/ansistyle/setup.py?rev=1.15&content-type=text/vnd.viewcvs-markup changing the strs to unicode objects doesn't fix the problem. Bye, Walter Dörwald
bdist_wininst has seen a lot of bug fixes and improvements, mostly by Mark, partly by me. I'd like to 'improve' the visual appearance, too.
One improvement would be proper treatment of Unicode. Currently it doesn't seem to be possible to use unicode objects with umlauts in the arguments to distutils.core.setup(). Some of my Windows packages say "Author: Walter Dxf6rwald"
Walter, can you try out the attached patch? It seems to work for me. Both for unicode and ascii strings as author name, containing an umlaut. Thanks, Thomas
Thomas Heller wrote:
bdist_wininst has seen a lot of bug fixes and improvements, mostly by Mark, partly by me. I'd like to 'improve' the visual appearance, too.
One improvement would be proper treatment of Unicode. Currently it doesn't seem to be possible to use unicode objects with umlauts in the arguments to distutils.core.setup(). Some of my Windows packages say "Author: Walter Dxf6rwald"
Walter, can you try out the attached patch? It seems to work for me. Both for unicode and ascii strings as author name, containing an umlaut.
Installing http://www.python.org/ftp/python/2.4/Python-2.4a1.msi, applying your patch to the CVS version and copying the distutils directory over C:\Programme\Python24\Lib\distutils gives me the following: c:\programme\python24\python setup.py bdist --formats=wininst running bdist running bdist_wininst running build running build_py Traceback (most recent call last): File "setup.py", line 50, in ? package_dir={"ll": ""} File "c:\programme\python24\lib\distutils\core.py", line 150, in setup dist.run_commands() File "c:\programme\python24\lib\distutils\dist.py", line 951, in run_commands self.run_command(cmd) File "c:\programme\python24\lib\distutils\dist.py", line 971, in run_command cmd_obj.run() File "c:\programme\python24\lib\distutils\command\bdist.py", line 146, in run self.run_command(cmd_name) File "c:\programme\python24\lib\distutils\cmd.py", line 333, in run_command self.distribution.run_command(command) File "c:\programme\python24\lib\distutils\dist.py", line 971, in run_command cmd_obj.run() File "c:\programme\python24\lib\distutils\command\bdist_wininst.py", line 127, in run assert self.skip_build, "Should have already checked this" AssertionError: Should have already checked this Bye, Walter Dörwald
Walter Dörwald <walter@livinglogic.de> writes:
Thomas Heller wrote:
bdist_wininst has seen a lot of bug fixes and improvements, mostly by Mark, partly by me. I'd like to 'improve' the visual appearance, too.
One improvement would be proper treatment of Unicode. Currently it doesn't seem to be possible to use unicode objects with umlauts in the arguments to distutils.core.setup(). Some of my Windows packages say "Author: Walter Dxf6rwald" Walter, can you try out the attached patch? It seems to work for me. Both for unicode and ascii strings as author name, containing an umlaut.
Installing http://www.python.org/ftp/python/2.4/Python-2.4a1.msi, applying your patch to the CVS version and copying the distutils directory over C:\Programme\Python24\Lib\distutils gives me the following: [...]
I doubt this traceback has to do with my patch. Can you try again, first without the patch, after doing 'cvs update -A', to make sure you have the most recent version? (We should probably move this to the SF tracker) Thomas
Thomas Heller wrote:
Walter Dörwald <walter@livinglogic.de> writes:
[...] Installing http://www.python.org/ftp/python/2.4/Python-2.4a1.msi, applying your patch to the CVS version and copying the distutils directory over C:\Programme\Python24\Lib\distutils gives me the following:
[...]
I doubt this traceback has to do with my patch. Can you try again, first without the patch, after doing 'cvs update -A', to make sure you have the most recent version? (We should probably move this to the SF tracker)
Thomas
Done: http://www.python.org/sf/993943 Bye, Walter Dörwald
[Thomas Heller]
... Second, the default bitmap it displays is the old Python Powered logo by Just (that with the cool license ;-). A much better bitmap would be that from <http://tinyurl.com/595xd>, which seems to have been made for the PSF. There are two problems with this image: The size is 122x261 pixels, while bdist_wininst would prefer 152x261 pixels. Maybe someone can recreate the icon with a changed size? The file size, when it is converted to 24-bit color bmp, is nearly 100 kB, which is a bit large imo for an optical gimmik - but this can probably be fixed by compressing the image in the installer itself. Finally, I'm not sure I'm allowed to use and redistribute this image.
That looks like a minor variant of the graphic Erik van Blokland-- a colleague of Just's --created for Python's Wise installer. Erik asked for an acknowledgement in return for the work, and that's why the Wise installer displayed this on its last (Installation Complete) screen: Special Windows thanks to: Wise Solutions, for the use of InstallMaster 8.1. http://www.wisesolutions.com/ LettError, Erik van Blokland, for the Python for Windows graphic. http://www.letterror.com/ Mark Hammond, without whose years of freely shared Windows expertise, Python for Windows would still be Python for DOS. So ask Just about this. I don't have a current email address for Erik. OTOH, the Python-Powered logo is quite recognizable now, and it's fine by me if bsdist_wininst just leaves this alone!
Third, the installer executable doesn't have an icon. Personally I don't care too much about that, but Phil Hornby made two icons which he posted to the distutils list (the gmane archives do a nice job to show the icons on the web page):
<http://article.gmane.org/gmane.comp.python.distutils.devel/852> <http://article.gmane.org/gmane.comp.python.distutils.devel/855>
For me, those both show little boxes with a red X, i.e. the image couldn't be loaded. Or maybe that's what they're supposed to look like <wink>.
Tim Peters <tim.peters@gmail.com> writes:
[Thomas Heller]
... Second, the default bitmap it displays is the old Python Powered logo by Just (that with the cool license ;-). A much better bitmap would be that from <http://tinyurl.com/595xd>, which seems to have been made for the PSF. There are two problems with this image: The size is 122x261 pixels, while bdist_wininst would prefer 152x261 pixels. Maybe someone can recreate the icon with a changed size? The file size, when it is converted to 24-bit color bmp, is nearly 100 kB, which is a bit large imo for an optical gimmik - but this can probably be fixed by compressing the image in the installer itself. Finally, I'm not sure I'm allowed to use and redistribute this image.
That looks like a minor variant of the graphic Erik van Blokland-- a colleague of Just's --created for Python's Wise installer. Erik asked for an acknowledgement in return for the work, and that's why the Wise installer displayed this on its last (Installation Complete) screen:
Special Windows thanks to:
Wise Solutions, for the use of InstallMaster 8.1. http://www.wisesolutions.com/
LettError, Erik van Blokland, for the Python for Windows graphic. http://www.letterror.com/
Mark Hammond, without whose years of freely shared Windows expertise, Python for Windows would still be Python for DOS.
So ask Just about this. I don't have a current email address for Erik.
OTOH, the Python-Powered logo is quite recognizable now, and it's fine by me if bsdist_wininst just leaves this alone!
The reason I was looking into this is that including an XP style manifest into wininst.exe was that the logo looks somewhat different then. It didn't fill any longer whole area of the static field. I will take a look if this can be fixed.
Third, the installer executable doesn't have an icon. Personally I don't care too much about that, but Phil Hornby made two icons which he posted to the distutils list (the gmane archives do a nice job to show the icons on the web page):
<http://article.gmane.org/gmane.comp.python.distutils.devel/852> <http://article.gmane.org/gmane.comp.python.distutils.devel/855>
For me, those both show little boxes with a red X, i.e. the image couldn't be loaded. Or maybe that's what they're supposed to look like <wink>.
The boxes with the red X's mean 'upgrade to Mozilla' ;-). (For me, the icons are displayed in Mozilla, but I see the red X's in IE as well). The pipermail urls are these <http://mail.python.org/pipermail/distutils-sig/2004-February/003704.html> <http://mail.python.org/pipermail/distutils-sig/2004-February/003707.html> they allow to download the icons. Thomas
participants (3)
-
Thomas Heller
-
Tim Peters
-
Walter Dörwald