I've finished rewriting the PyNumber_InPlace*() calls in the augmented assignment patch and am about to check the entire thing in. I'll be checking it in in parts, with the grammar/compile/ceval things last, but you might get some weird errors in the next hour or so, depending on my link to sourceforge. (I'm doing some last minute checks before checking it in ;) Part of it will be docs, but not terribly much yet. I'm still working on those, though, and I have a bit over a week before I leave on vacation, so I think I can finish them for the most part.) I'm also checking in a test case, and some modifications to the std library: support for += in UserList, UserDict, UserString, and rfc822.Addresslist. Reviewers are more than welcome, though I realize how large a patch it is. (Boy, do I realize that!) -- Thomas Wouters <thomas@xs4all.net> Hi! I'm a .signature virus! copy me into your .signature file to help me spread!
Congratulations, Thomas! Megathanks for carrying this proposal to a happy ending. I'm looking forward to using the new feature! Nits: Lib/symbol.py and Lib/token.py need to be regenerated and checked in; (see the comments at the top of the file). Also, tokenizer.py probably needs to have the new tokens += etc. added manually. --Guido van Rossum (home page: http://www.pythonlabs.com/~guido/)
On Thu, Aug 24, 2000 at 04:45:53PM -0500, Guido van Rossum wrote:
Nits: Lib/symbol.py and Lib/token.py need to be regenerated and checked in; (see the comments at the top of the file).
Checking them in now.
Also, tokenizer.py probably needs to have the new tokens += etc. added manually.
Okay. I'm not entirely sure how to do this, but I *think* this does it: replace Operator = group('\+', '\-', '\*\*', '\*', '\^', '~', '/', '%', '&', '\|', '<<', '>>', '==', '<=', '<>', '!=', '>=', '=', '<', '>') with Operator = group('\+=', '\-=', '\*=', '%=', '/=', '\*\*=', '&=', '\|=', '\^=', '>>=', '<<=', '\+', '\-', '\*\*', '\*', '\^', '~', '/', '%', '&', '\|', '<<', '>>', '==', '<=', '<>', '!=', '>=', '=', '<', '>') Placing the augmented-assignment operators at the end doesn't work, but this seems to do the trick. However, I can't really test this module, just check its output. It seems okay, but I would appreciate either an 'okay' or a more extensive test before checking it in. No, I can't start IDLE right now, I'm working over a 33k6 leased line and my home machine doesn't have an augmented Python yet :-) -- Thomas Wouters <thomas@xs4all.net> Hi! I'm a .signature virus! copy me into your .signature file to help me spread!
participants (2)
-
Guido van Rossum -
Thomas Wouters