[Python-checkins] Daily reference leaks (8391f99208f6): sum=181
I think the memory leak was caused by http://hg.python.org/cpython/rev/7d20e30bd540 because http://hg.python.org/cpython/file/0eedac3d0b0a/Python/import.c#l903 sets the 'res' variable and then overwrites it unconditionally w/o PY_DECREF beforehand. On Thu May 29 2014 at 4:02:17 AM, <solipsis@pitrou.net> wrote:
results for 8391f99208f6 on branch "default" --------------------------------------------
test_collections leaked [0, 2, 4] references, sum=6 test_collections leaked [0, 1, 2] memory blocks, sum=3 test_functools leaked [0, 0, 3] memory blocks, sum=3 test_importlib leaked [5, 5, 5] references, sum=15 test_pkgutil leaked [1, 1, 1] references, sum=3 test_site leaked [0, 0, 2] references, sum=2 test_site leaked [0, 0, 2] memory blocks, sum=2 test_zipimport leaked [47, 47, 47] references, sum=141 test_zipimport_support leaked [2, 2, 2] references, sum=6
Command line was: ['./python', '-m', 'test.regrtest', '-uall', '-R', '3:3:/home/antoine/cpython/refleaks/reflogDdbYzY', '-x'] _______________________________________________ Python-checkins mailing list Python-checkins@python.org https://mail.python.org/mailman/listinfo/python-checkins
Good catch. I'll look into it. -eric On Thu, May 29, 2014 at 8:49 AM, Brett Cannon <bcannon@gmail.com> wrote:
I think the memory leak was caused by http://hg.python.org/cpython/rev/7d20e30bd540 because http://hg.python.org/cpython/file/0eedac3d0b0a/Python/import.c#l903 sets the 'res' variable and then overwrites it unconditionally w/o PY_DECREF beforehand.
On Thu May 29 2014 at 4:02:17 AM, <solipsis@pitrou.net> wrote:
results for 8391f99208f6 on branch "default" --------------------------------------------
test_collections leaked [0, 2, 4] references, sum=6 test_collections leaked [0, 1, 2] memory blocks, sum=3 test_functools leaked [0, 0, 3] memory blocks, sum=3 test_importlib leaked [5, 5, 5] references, sum=15 test_pkgutil leaked [1, 1, 1] references, sum=3 test_site leaked [0, 0, 2] references, sum=2 test_site leaked [0, 0, 2] memory blocks, sum=2 test_zipimport leaked [47, 47, 47] references, sum=141 test_zipimport_support leaked [2, 2, 2] references, sum=6
Command line was: ['./python', '-m', 'test.regrtest', '-uall', '-R', '3:3:/home/antoine/cpython/refleaks/reflogDdbYzY', '-x'] _______________________________________________ Python-checkins mailing list Python-checkins@python.org https://mail.python.org/mailman/listinfo/python-checkins
Fixed! (test_site and test_functools are still leaking sporadically, but it looks unrelated to the import.c leak). -eric On Thu, May 29, 2014 at 10:34 AM, Eric Snow <ericsnowcurrently@gmail.com> wrote:
Good catch. I'll look into it.
-eric
On Thu, May 29, 2014 at 8:49 AM, Brett Cannon <bcannon@gmail.com> wrote:
I think the memory leak was caused by http://hg.python.org/cpython/rev/7d20e30bd540 because http://hg.python.org/cpython/file/0eedac3d0b0a/Python/import.c#l903 sets the 'res' variable and then overwrites it unconditionally w/o PY_DECREF beforehand.
On Thu May 29 2014 at 4:02:17 AM, <solipsis@pitrou.net> wrote:
results for 8391f99208f6 on branch "default" --------------------------------------------
test_collections leaked [0, 2, 4] references, sum=6 test_collections leaked [0, 1, 2] memory blocks, sum=3 test_functools leaked [0, 0, 3] memory blocks, sum=3 test_importlib leaked [5, 5, 5] references, sum=15 test_pkgutil leaked [1, 1, 1] references, sum=3 test_site leaked [0, 0, 2] references, sum=2 test_site leaked [0, 0, 2] memory blocks, sum=2 test_zipimport leaked [47, 47, 47] references, sum=141 test_zipimport_support leaked [2, 2, 2] references, sum=6
Command line was: ['./python', '-m', 'test.regrtest', '-uall', '-R', '3:3:/home/antoine/cpython/refleaks/reflogDdbYzY', '-x'] _______________________________________________ Python-checkins mailing list Python-checkins@python.org https://mail.python.org/mailman/listinfo/python-checkins
participants (2)
-
Brett Cannon -
Eric Snow