At 2502 lines, _cursesmodule.c is cumbersomely large. I've just received a patch from Thomas Gellekum that adds support for the panel library that will add another 500 lines. I'd like to split the C file into several subfiles (_curses_panel.c, _curses_window.c, etc.) that get #included from the master _cursesmodule.c file. Do the powers that be approve of this idea? --amk
A.M. Kuchling <amk@mira.erols.com>:
I doubt I qualify as a power that be, but I'm certainly +1 on panel support. -- <a href="http://www.tuxedo.org/~esr/">Eric S. Raymond</a> The biggest hypocrites on gun control are those who live in upscale developments with armed security guards -- and who want to keep other people from having guns to defend themselves. But what about lower-income people living in high-crime, inner city neighborhoods? Should such people be kept unarmed and helpless, so that limousine liberals can 'make a statement' by adding to the thousands of gun laws already on the books?" --Thomas Sowell
[CC'ing Thomas Gellekum <tg@melaten.rwth-aachen.de>] On Wed, Dec 13, 2000 at 01:24:01AM -0500, Fred L. Drake, Jr. wrote:
Quite possibly, though the patch isn't structured that way. The panel module will need access to the type object for the curses window object, so it'll have to ensure that _curses is already imported, but that's no problem. Thomas, do you feel capable of implementing it as a separate module, or should I work on it? Probably a _cursesmodule.h header will have to be created to make various definitions available to external users of the basic objects in _curses. (Bonus: this means that the menu and form libraries, if they ever get wrapped, can be separate modules, too.) --amk
On Tue, Dec 12, 2000 at 10:55:33PM -0500, A.M. Kuchling wrote:
Why should they be #included? I thought that we can build multiple .c files into a module... Cheers, -g -- Greg Stein, http://www.lyra.org/
A.M. Kuchling <amk@mira.erols.com>:
I doubt I qualify as a power that be, but I'm certainly +1 on panel support. -- <a href="http://www.tuxedo.org/~esr/">Eric S. Raymond</a> The biggest hypocrites on gun control are those who live in upscale developments with armed security guards -- and who want to keep other people from having guns to defend themselves. But what about lower-income people living in high-crime, inner city neighborhoods? Should such people be kept unarmed and helpless, so that limousine liberals can 'make a statement' by adding to the thousands of gun laws already on the books?" --Thomas Sowell
[CC'ing Thomas Gellekum <tg@melaten.rwth-aachen.de>] On Wed, Dec 13, 2000 at 01:24:01AM -0500, Fred L. Drake, Jr. wrote:
Quite possibly, though the patch isn't structured that way. The panel module will need access to the type object for the curses window object, so it'll have to ensure that _curses is already imported, but that's no problem. Thomas, do you feel capable of implementing it as a separate module, or should I work on it? Probably a _cursesmodule.h header will have to be created to make various definitions available to external users of the basic objects in _curses. (Bonus: this means that the menu and form libraries, if they ever get wrapped, can be separate modules, too.) --amk
On Tue, Dec 12, 2000 at 10:55:33PM -0500, A.M. Kuchling wrote:
Why should they be #included? I thought that we can build multiple .c files into a module... Cheers, -g -- Greg Stein, http://www.lyra.org/
participants (5)
-
A.M. Kuchling -
Andrew Kuchling -
Eric S. Raymond -
Fred L. Drake, Jr. -
Greg Stein