On Wed, Apr 1, 2009 at 3:25 PM, Benjamin Peterson wrote:

2009/4/1 David Christian :

...

Hi all, I've recently written a C version of the trace function used in figleaf (the coverage tool written by Titus).  After a few rewrites to add in caching, etc, it gives users a significant speedup.  One person stated that switching to the C version caused coverage to decrease from a 442% slowdown to only a 56% slowdown.

You can see my C implementation at:  http://github.com/ctb/figleaf/blob/e077155956c288b68704b09889ebcd675ba02240/...

(Specific comments about the implementation welcome off-list).

I'd like to attempt something similar for bdb.py (only for the trace function).  A naive C trace function which duplicated the current python function should speed up bdb significantly.  I would initially write the smallest part of the C implementation that I could. Basically the tracing function would call back out to python at any point where a line requires action.

I'd be willing to maintain the C implementation.  I would be willing to write those tests that are possible as well.

Is this something that would be likely to be accepted?

Generally debugging doesn't require good performance, so this is definitely low priority. However, if you can contribute it, I don't have a problem with it.

Tracing has other uses besides debugging though. In particular, coverage, which usually wants per-line data. Also, sometimes if you set a breakpoint in a function it turns on tracing for the entire function. This can sometimes be annoyingly slow. So, personally, I am more positive than that, and hope it will make it in. -- --Guido van Rossum (home page: http://www.python.org/~guido/)

On 2009-04-01 17:53, Benjamin Peterson wrote:

2009/4/1 Guido van Rossum:

...

Tracing has other uses besides debugging though.

The OP said he wished to implement a C trace function for bdb. Wouldn't that make it only applicable to debugging?

Once you are at the breakpoint and stepping through the code manually, the performance is not all that important. However, up until that breakpoint, you are running a lot of code "in bulk". It would be useful to have a performant trace function that interferes with that code the least. -- Robert Kern "I have come to believe that the whole world is an enigma, a harmless enigma that is made terrible by our own mad attempt to interpret it as though it had an underlying truth." -- Umberto Eco

On Wed, Apr 1, 2009 at 3:53 PM, Benjamin Peterson wrote:

2009/4/1 Guido van Rossum :

...

Tracing has other uses besides debugging though.

The OP said he wished to implement a C trace function for bdb. Wouldn't that make it only applicable to debugging?

I honestly don't recall, but I believe pretty much everyone who uses tracing does so via bdb.py. And yes, when debugging sometimes you have to silently skip 1000 iterations until a condition becomes true, and the tracking speed matters. -- --Guido van Rossum (home page: http://www.python.org/~guido/)