[bpo-35155] Requesting a review
Hello all, A couple months back, I reported bpo-35155[1] and I submitted a PR for consideration[2]. After a couple of reviews, it seems like progress has stalled. Would it be possible for someone to review this? Thanks, Denton [1]: https://bugs.python.org/issue35155 [2]: https://github.com/python/cpython/pull/10313
On 2/12/2019 5:14 AM, Denton Liu wrote:
Hello all,
A couple months back, I reported bpo-35155[1] and I submitted a PR for consideration[2]. After a couple of reviews, it seems like progress has stalled. Would it be possible for someone to review this?
Thanks,
Denton
[1]: https://bugs.python.org/issue35155 [2]: https://github.com/python/cpython/pull/10313
The problem is that the urllib.request doc has several 'placeholder-literal' and 'literal-placeholder' constructs where 'literal' is text that the user *must copy* while 'placeholder' is text that the user *must replace* with one of several strings, with no evident indication of which is which. (The constructs indicate possible allowed names of user-supplied functions.) The only issue to me is how to indicate in the .rst source (and resulting html) that 'placeholder' is a placeholder and not a literal. -- Terry Jan Reedy
On 2/12/2019 3:24 PM, Terry Reedy wrote:
The problem is that the urllib.request doc has several 'placeholder-literal' and 'literal-placeholder' constructs where
Correction: The result must be a legal function name, so that should be 'placeholder_literal' and 'literal_placeholder', where the '_' is part of the literal. -- Terry Jan Reedy
On Tue, Feb 12, 2019 at 02:14:55AM -0800, Denton Liu wrote:
Hello all,
A couple months back, I reported bpo-35155[1] and I submitted a PR for consideration[2]. After a couple of reviews, it seems like progress has stalled. Would it be possible for someone to review this?
Thanks,
Denton
[1]: https://bugs.python.org/issue35155 [2]: https://github.com/python/cpython/pull/10313
Thanks for the comments and help on the PR! It seems like progress on this change has stalled again. If there aren't anymore comments, I believe that this PR is ready to be merged. Thanks, Denton
On Tue, Feb 26, 2019 at 10:40:56PM -0800, Denton Liu wrote:
On Tue, Feb 12, 2019 at 02:14:55AM -0800, Denton Liu wrote:
Hello all,
A couple months back, I reported bpo-35155[1] and I submitted a PR for consideration[2]. After a couple of reviews, it seems like progress has stalled. Would it be possible for someone to review this?
Thanks,
Denton
[1]: https://bugs.python.org/issue35155 [2]: https://github.com/python/cpython/pull/10313
Thanks for the comments and help on the PR!
It seems like progress on this change has stalled again. If there aren't anymore comments, I believe that this PR is ready to be merged.
Thanks,
Denton
Hello all, It seems like the reviews on the PR are still stalled. Would it be possible for someone to take a look? If there aren't anymore comments, I believe that the PR is ready to be merged. Thanks, Denton
participants (2)
-
Denton Liu -
Terry Reedy