[bpo-35155] Requesting a review

Hello all, A couple months back, I reported bpo-35155[1] and I submitted a PR for consideration[2]. After a couple of reviews, it seems like progress has stalled. Would it be possible for someone to review this? Thanks, Denton [1]: https://bugs.python.org/issue35155 [2]: https://github.com/python/cpython/pull/10313

On 2/12/2019 5:14 AM, Denton Liu wrote:
The problem is that the urllib.request doc has several 'placeholder-literal' and 'literal-placeholder' constructs where 'literal' is text that the user *must copy* while 'placeholder' is text that the user *must replace* with one of several strings, with no evident indication of which is which. (The constructs indicate possible allowed names of user-supplied functions.) The only issue to me is how to indicate in the .rst source (and resulting html) that 'placeholder' is a placeholder and not a literal. -- Terry Jan Reedy

On 2/12/2019 3:24 PM, Terry Reedy wrote:
The problem is that the urllib.request doc has several 'placeholder-literal' and 'literal-placeholder' constructs where
Correction: The result must be a legal function name, so that should be 'placeholder_literal' and 'literal_placeholder', where the '_' is part of the literal. -- Terry Jan Reedy

On 2/12/2019 5:14 AM, Denton Liu wrote:
The problem is that the urllib.request doc has several 'placeholder-literal' and 'literal-placeholder' constructs where 'literal' is text that the user *must copy* while 'placeholder' is text that the user *must replace* with one of several strings, with no evident indication of which is which. (The constructs indicate possible allowed names of user-supplied functions.) The only issue to me is how to indicate in the .rst source (and resulting html) that 'placeholder' is a placeholder and not a literal. -- Terry Jan Reedy

On 2/12/2019 3:24 PM, Terry Reedy wrote:
The problem is that the urllib.request doc has several 'placeholder-literal' and 'literal-placeholder' constructs where
Correction: The result must be a legal function name, so that should be 'placeholder_literal' and 'literal_placeholder', where the '_' is part of the literal. -- Terry Jan Reedy
participants (2)
-
Denton Liu
-
Terry Reedy