Re: [Python-Dev] r85960 - python/branches/py3k/Lib/test/test_mailbox.py
On Sat, 30 Oct 2010 02:13:01 +0200 (CEST)
brett.cannon
Author: brett.cannon Date: Sat Oct 30 02:13:00 2010 New Revision: 85960
Log: Silence some ResourceWarning in test_mailbox by using file context managers.
Unfortunately, these file-like objects don't support the context management protocol: ====================================================================== ERROR: test_get_file (test.test_mailbox.TestMaildir) ---------------------------------------------------------------------- Traceback (most recent call last): File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_mailbox.py", line 168, in test_get_file with self._box.get_file(key0) as file: AttributeError: __exit__ ====================================================================== ERROR: test_get_file (test.test_mailbox.TestMbox) ---------------------------------------------------------------------- Traceback (most recent call last): File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_mailbox.py", line 168, in test_get_file with self._box.get_file(key0) as file: AttributeError: __exit__ ====================================================================== ERROR: test_get_file (test.test_mailbox.TestMMDF) ---------------------------------------------------------------------- Traceback (most recent call last): File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_mailbox.py", line 168, in test_get_file with self._box.get_file(key0) as file: AttributeError: __exit__ ====================================================================== ERROR: test_get_file (test.test_mailbox.TestMH) ---------------------------------------------------------------------- Traceback (most recent call last): File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_mailbox.py", line 168, in test_get_file with self._box.get_file(key0) as file: AttributeError: __exit__
Am 30.10.2010 12:12, schrieb Antoine Pitrou:
On Sat, 30 Oct 2010 02:13:01 +0200 (CEST) brett.cannon
wrote: Author: brett.cannon Date: Sat Oct 30 02:13:00 2010 New Revision: 85960
Log: Silence some ResourceWarning in test_mailbox by using file context managers.
Unfortunately, these file-like objects don't support the context management protocol
Should be fixed in r85979. Do we want Mailboxes themselves to be context managers? Georg -- Thus spake the Lord: Thou shalt indent with four spaces. No more, no less. Four shall be the number of spaces thou shalt indent, and the number of thy indenting shall be four. Eight shalt thou not indent, nor either indent thou two, excepting that thou then proceed to four. Tabs are right out.
participants (2)
-
Antoine Pitrou
-
Georg Brandl