rename of ConfigParser module?
Trying to build pywin32 from the trunk, I see: from distutils.config import PyPIRCCommand File "C:\src\python-svn\lib\distutils\config.py", line 8, in <module> from ConfigParser import ConfigParser ImportError: No module named ConfigParser Digging a little deeper, I see: |r63242 | alexandre.vassalotti | 2008-05-15 08:07:07 +1000 (Thu, 15 May 2008) | 2 lines | |Renamed the ConfigParser module to 'configparser'. Is there something I've missed? Cheers, Mark
On Thu, May 15, 2008 at 7:37 AM, Mark Hammond <mhammond@skippinet.com.au> wrote:
Trying to build pywin32 from the trunk, I see:
from distutils.config import PyPIRCCommand File "C:\src\python-svn\lib\distutils\config.py", line 8, in <module> from ConfigParser import ConfigParser ImportError: No module named ConfigParser
Digging a little deeper, I see:
|r63242 | alexandre.vassalotti | 2008-05-15 08:07:07 +1000 (Thu, 15 May 2008) | 2 lines | |Renamed the ConfigParser module to 'configparser'.
Is there something I've missed?
Mark Hammond wrote:
Trying to build pywin32 from the trunk, I see:
from distutils.config import PyPIRCCommand File "C:\src\python-svn\lib\distutils\config.py", line 8, in <module> from ConfigParser import ConfigParser ImportError: No module named ConfigParser
Digging a little deeper, I see:
|r63242 | alexandre.vassalotti | 2008-05-15 08:07:07 +1000 (Thu, 15 May 2008) | 2 lines | |Renamed the ConfigParser module to 'configparser'.
Is there something I've missed?
My money would be on the warning from the build process that Modules/Setup.dist is newer than Modules/Setup :) To keep NTFS and any other case insensitive filesystems from choking on module renames which only differ by case, the old names have been moved to the lib-old directory. You need the newer Setup file to get that directory to appear in sys.path. (Hmm, is changing Modules/Setup enough to sort the Windows build out as well? Or does that need a separate change to some of the Visual Studio files?) Cheers, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia --------------------------------------------------------------- http://www.boredomandlaziness.org
(Hmm, is changing Modules/Setup enough to sort the Windows build out as well? Or does that need a separate change to some of the Visual Studio files?)
The latter. Whenever you add, remove, or rename an extension module, you need to adjust the PCbuild files as well. (technically, you also have to adjust PC/os2emx/Makefile, PC/os2vacpp/makefile.omk, and PC/VC6, but these changes are waived). Regards, Martin
Martin v. Löwis schrieb:
(Hmm, is changing Modules/Setup enough to sort the Windows build out as well? Or does that need a separate change to some of the Visual Studio files?)
The latter. Whenever you add, remove, or rename an extension module, you need to adjust the PCbuild files as well. (technically, you also have to adjust PC/os2emx/Makefile, PC/os2vacpp/makefile.omk, and PC/VC6, but these changes are waived).
Don't forget PC/config.c and the build files for VC 6, VS 7.1 and VS 8.0 in the PC/ directory. :] Christian
Martin v. Löwis schrieb:
Don't forget PC/config.c and the build files for VC 6, VS 7.1 and VS 8.0 in the PC/ directory. :]
Aren't the 7.1 and 8.0 files generated?
Only the 8.0 files are generated from the 9.0 files. The 6.0 and 7.1 files still require manual work. It might be possible to create the 7.1 files from the 9.0 as well. But nobody has written a tool so far. Christian
(Hmm, is changing Modules/Setup enough to sort the Windows build out as well? Or does that need a separate change to some of the Visual Studio files?)
The latter. Whenever you add, remove, or rename an extension module, you need to adjust the PCbuild files as well. (technically, you also have to adjust PC/os2emx/Makefile, PC/os2vacpp/makefile.omk, and PC/VC6, but these changes are waived).
Correct me if I'm wrong, but in this case we are talking about adding a new directory to sys.path, correct? On Windows, this means a change in PCBuild/pyconfig.h and tools/msi/msi.py. A patch seems simple, so I'll check one in (assuming noone beats me) after clarification of a couple of points. * I assume lib-old should go at the end of the sys.path managed by the above files? * What is the story with "plat-win"? pyconfig.h includes a 'Lib\plat-win' directory, and although this directory does not exist, it usually ends up on sys.path. msi.py does *not* include this entry, which means it doesn't end up on sys.path in certain embedding environments (specifically, when the hosting application is using a python.dll located outside the Python directory). I'm sure there are pros and cons for including that directory, but I can't see justification for it to sometimes be used and sometimes not. So should I change msi.py to include this directory, or change pyconfig.h to not include it? Thanks, Mark
On Thu, May 15, 2008 at 4:35 PM, Mark Hammond <mhammond@skippinet.com.au> wrote:
(Hmm, is changing Modules/Setup enough to sort the Windows build out as well? Or does that need a separate change to some of the Visual Studio files?)
The latter. Whenever you add, remove, or rename an extension module, you need to adjust the PCbuild files as well. (technically, you also have to adjust PC/os2emx/Makefile, PC/os2vacpp/makefile.omk, and PC/VC6, but these changes are waived).
Correct me if I'm wrong, but in this case we are talking about adding a new directory to sys.path, correct? On Windows, this means a change in PCBuild/pyconfig.h and tools/msi/msi.py. A patch seems simple, so I'll check one in (assuming noone beats me) after clarification of a couple of points.
* I assume lib-old should go at the end of the sys.path managed by the above files?
Yes. -Brett
Martin v. Lo"wis wrote:
(Hmm, is changing Modules/Setup enough to sort the Windows build out as well? Or does that need a separate change to some of the Visual Studio files?)
The latter. Whenever you add, remove, or rename an extension module, you need to adjust the PCbuild files as well. (technically, you also have to adjust PC/os2emx/Makefile, PC/os2vacpp/makefile.omk, and PC/VC6, but these changes are waived).
OS/2 fixes are something I'll address during the betas. -- ------------------------------------------------------------------------- Andrew I MacIntyre "These thoughts are mine alone..." E-mail: andymac@bullseye.apana.org.au (pref) | Snail: PO Box 370 andymac@pcug.org.au (alt) | Belconnen ACT 2616 Web: http://www.andymac.org/ | Australia
participants (7)
-
"Martin v. Löwis" -
Alexander Michael -
Andrew MacIntyre -
Brett Cannon -
Christian Heimes -
Mark Hammond -
Nick Coghlan