Re: [Python-Dev] [Python-checkins] cpython: Issue #11651: Improve Makefile test targets.
On Sun, Jul 31, 2011 at 9:09 AM, nadeem.vawda <python-checkins@python.org> wrote:
http://hg.python.org/cpython/rev/b76684d62a8d changeset: 71645:b76684d62a8d user: Nadeem Vawda <nadeem.vawda@gmail.com> date: Sun Jul 31 01:09:04 2011 +0200 summary: Issue #11651: Improve Makefile test targets.
- Use -j0 option by default - Remove duplicate test run in "make test" and "make testuniversal"
That seems very questionable - the rationale for running the test suite twice by default to ensure PYC generation is working correctly still holds. Cheers, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
On Sun, Jul 31, 2011 at 10:26 AM, Nick Coghlan <ncoghlan@gmail.com> wrote:
On Sun, Jul 31, 2011 at 9:09 AM, nadeem.vawda <python-checkins@python.org> wrote:
- Remove duplicate test run in "make test" and "make testuniversal"
That seems very questionable - the rationale for running the test suite twice by default to ensure PYC generation is working correctly still holds.
The consensus on the tracker was that it isn't worth doubling the time taken to run "make test" to check for a class of bug that seems to be relatively rare. For changes that touch anything as far-reaching as .pyc generation, you should be using "make testall" anyway (and that does still use two passes). Cheers, Nadeem
On Jul 31, 2011, at 06:26 PM, Nick Coghlan wrote:
That seems very questionable - the rationale for running the test suite twice by default to ensure PYC generation is working correctly still holds.
Agreed. I'd at least like to have seen discussion on python-dev instead of just in the tracker. FWIW, I wasn't even aware of this issue. -Barry
On Jul 31, 2011, at 06:55 AM, Barry Warsaw wrote:
On Jul 31, 2011, at 06:26 PM, Nick Coghlan wrote:
That seems very questionable - the rationale for running the test suite twice by default to ensure PYC generation is working correctly still holds.
Agreed. I'd at least like to have seen discussion on python-dev instead of just in the tracker. FWIW, I wasn't even aware of this issue.
Er, nm. I need coffee. -B
On Sun, 31 Jul 2011 18:26:42 +1000 Nick Coghlan <ncoghlan@gmail.com> wrote:
On Sun, Jul 31, 2011 at 9:09 AM, nadeem.vawda <python-checkins@python.org> wrote:
http://hg.python.org/cpython/rev/b76684d62a8d changeset: 71645:b76684d62a8d user: Nadeem Vawda <nadeem.vawda@gmail.com> date: Sun Jul 31 01:09:04 2011 +0200 summary: Issue #11651: Improve Makefile test targets.
- Use -j0 option by default - Remove duplicate test run in "make test" and "make testuniversal"
That seems very questionable - the rationale for running the test suite twice by default to ensure PYC generation is working correctly still holds.
But nobody did it anyway, even the buildbots. Regards Antoine.
participants (4)
-
Antoine Pitrou -
Barry Warsaw -
Nadeem Vawda -
Nick Coghlan