Hello, just felt a little bored and tried to review a few (no-brainer) patches. Here are the results: * Patch #1051395 Minor fix in Lib/locale.py: Docs say that function _parse_localename returns a tuple; but for one codepath it returns a list. Patch fixes this by adding tuple(), recommending apply. * Patch #1046831 Minor fix in Lib/distutils/sysconfig.py: it defines a function to retrieve the Python version but does not use it everywhere; Patch fixes this, recommending apply. * Patch #751031 Adds recognizing JPEG-EXIF files (produced by digicams) to imghdr.py. Recommending apply. * Patch #712317 Fixes URL parsing in urlparse for URLs such as http://foo?bar. Splits at '?', so assigns 'foo' to netloc and 'bar' to query instead of assigning 'foo?bar' to netloc. Recommending apply. regards, Reinhold
Reinhold Birkenfeld wrote:
just felt a little bored and tried to review a few (no-brainer) patches.
Thanks! They are now all closed. Please understand that there is a chance that a review posted *only* to python-dev might get lost/overlooked by the committers, and then somebody may need to duplicate your work later. So it is better to include the review in the patch, and only post a summary to python-dev. Regards, Martin
participants (3)
-
"Martin v. Löwis"
-
Raymond Hettinger
-
Reinhold Birkenfeld