Re: [Python-Dev] Re: [Bug #121013] Bug in <stringobject>.join(<unicodestring>)
Michael Hudson <mwh21@cam.ac.uk> writes:
"M.-A. Lemburg" <mal@lemburg.com> writes:
Date: 2000-Nov-27 10:12 By: mwh
Comment: I hope you're all suitably embarrassed - please see patch #102548 for the trivial fix...
Hehe, that was indeed a trivial patch. What was that about trees in a forest...
The way I found it was perhaps instructive. I was looking at the function, and thought "that's a bit complicated" so I rewrote it (My rewrite also seems to be bit quicker so I'll upload it as soon as make test has finished[*]).
It's at https://sourceforge.net/patch/index.php?func=detailpatch&patch_id=102549&group_id=5470 I want a way of submitting patches by email. Is roundup in a usable state yet? Cheers, M. -- "The future" has arrived but they forgot to update the docs. -- R. David Murray, 9 May 2000
Michael Hudson wrote:
The way I found it was perhaps instructive. I was looking at the function, and thought "that's a bit complicated" so I rewrote it (My rewrite also seems to be bit quicker so I'll upload it as soon as make test has finished[*]).
your patch changes the behaviour of join on non-standard sequences. if you use join on a long synthetic sequence, your new version may run out of memory where the old one worked just fine. not sure that's a good idea. -0 </F>
test_unicodedata is failing for me on Linux. Fredrik, you made a change on Nov. 3 that changed test/output/test_unicodedata but not test/test_unicodedata.pu. Did you verify that the test suite worked then? Jeremy
Jeremy wrote:
test_unicodedata is failing for me on Linux. Fredrik, you made a change on Nov. 3 that changed test/output/test_unicodedata but not test/test_unicodedata.pu. Did you verify that the test suite worked then?
I added 38,000 missing characters to the unicode database. that didn't change the test, only the test output... the november 3 checkin included the following files: Lib/test/output/test_unicodedata Modules/unicodedata_db.h Objects/unicodetype_db.h Tools/unicode/makeunicodedata.py ::: hmm. looks like the makefile dependencies haven't been updated (is this done by hand on Unix???) in Modules/Makefile.pre.in unicodedatabase.o: unicodedatabase.c unicodedatabase.h should be unicodedatabase.o: unicodedatabase.c unicodedatabase.h unicodedata_db.h and in Objects/Makefile.in unicodectype.o: unicodectype.c should be: unicodectype.o: unicodectype.c unicodectype_db.h </F>
On Tue, 28 Nov 2000, Fredrik Lundh wrote:
Jeremy wrote:
test_unicodedata is failing for me on Linux. Fredrik, you made a change on Nov. 3 that changed test/output/test_unicodedata but not test/test_unicodedata.pu. Did you verify that the test suite worked then?
I added 38,000 missing characters to the unicode database. that didn't change the test, only the test output...
the november 3 checkin included the following files:
Lib/test/output/test_unicodedata Modules/unicodedata_db.h Objects/unicodetype_db.h Tools/unicode/makeunicodedata.py
:::
hmm. looks like the makefile dependencies haven't been updated (is this done by hand on Unix???)
I think so. I've done a complete rebuild and the test now passes (I was sure I'd done one of those more recently than Nov 3...). So, false alarm, sorry. Cheers, M.
participants (4)
-
barry@digicool.com
-
Fredrik Lundh
-
Jeremy Hylton
-
Michael Hudson