Re: [Python-Dev] [Python-checkins] cpython: Issue #20383: Introduce importlib.util.module_from_spec().
On Fri, May 30, 2014 at 12:55 PM, brett.cannon <python-checkins@python.org> wrote:
http://hg.python.org/cpython/rev/b26d021081d2 changeset: 90915:b26d021081d2 parent: 90913:69011f6ce573 user: Brett Cannon <brett@python.org> date: Fri May 30 14:55:29 2014 -0400 summary: Issue #20383: Introduce importlib.util.module_from_spec().
diff --git a/Lib/importlib/_bootstrap.py b/Lib/importlib/_bootstrap.py --- a/Lib/importlib/_bootstrap.py +++ b/Lib/importlib/_bootstrap.py @@ -581,20 +581,19 @@ return loader
-def _load_module_shim(self, fullname): +def _load_module_shim(spec, fullname): """Load the specified module into sys.modules and return it.
This should have stayed "self", no? -eric
On Fri May 30 2014 at 3:39:47 PM, Eric Snow <ericsnowcurrently@gmail.com> wrote:
On Fri, May 30, 2014 at 12:55 PM, brett.cannon <python-checkins@python.org> wrote:
http://hg.python.org/cpython/rev/b26d021081d2 changeset: 90915:b26d021081d2 parent: 90913:69011f6ce573 user: Brett Cannon <brett@python.org> date: Fri May 30 14:55:29 2014 -0400 summary: Issue #20383: Introduce importlib.util.module_from_spec().
diff --git a/Lib/importlib/_bootstrap.py b/Lib/importlib/_bootstrap.py --- a/Lib/importlib/_bootstrap.py +++ b/Lib/importlib/_bootstrap.py @@ -581,20 +581,19 @@ return loader
-def _load_module_shim(self, fullname): +def _load_module_shim(spec, fullname): """Load the specified module into sys.modules and return it.
This should have stayed "self", no?
Yes. Fixed with an added comment to explain why since it isn't obvious in isolation.
participants (2)
-
Brett Cannon -
Eric Snow