Re: [Python-checkins] python/dist/src/Python future.c, 2.14, 2.15
On Saturday 05 February 2005 05:38, jhylton@users.sourceforge.net wrote:
Fix bug that allowed future statements virtually anywhere in a module.
If we exit via the break here, we need to set ff_last_lineno or FUTURE_POSSIBLE() will remain true. The bug affected statements containing a variety of expressions, but not all expressions. It has been present since Python 2.2.
While this is undoubtedly a bug fix, I'm not sure that it should be backported - it will break people's code that is "working" now (albeit in a faulty way). What do people think? -- Anthony Baxter <anthony@interlink.com.au> It's never too late to have a happy childhood.
[Anthony]
While this is undoubtedly a bug fix, I'm not sure that it should be backported - it will break people's code that is "working" now (albeit in a faulty way). What do people think?
I concur -- the balance of risks is towards the patch causing more harm than good. Raymond
On Sat, 5 Feb 2005 02:31:26 -0500, Raymond Hettinger <python@rcn.com> wrote:
[Anthony]
While this is undoubtedly a bug fix, I'm not sure that it should be backported - it will break people's code that is "working" now (albeit in a faulty way). What do people think?
I concur -- the balance of risks is towards the patch causing more harm than good.
I would not backport it to Python 2.3. People have been using it for a long time. I'd be inclined to backport it to Python 2.4, which is still relatively new. If someone has buggy code, an upgrade is going to cause a problem for them at some point. Given how unlikely the risk is -- particularly given that division is the only useful future now -- I'd say the risk is acceptable for Python 2.4.1. (Unlike, say, Python 2.4.2.) Jeremy
On 2005 Feb 05, at 16:49, Jeremy Hylton wrote:
On Sat, 5 Feb 2005 02:31:26 -0500, Raymond Hettinger <python@rcn.com> wrote:
[Anthony]
While this is undoubtedly a bug fix, I'm not sure that it should be backported - it will break people's code that is "working" now (albeit in a faulty way). What do people think?
I concur -- the balance of risks is towards the patch causing more harm than good.
I would not backport it to Python 2.3. People have been using it for a long time. I'd be inclined to backport it to Python 2.4, which is still relatively new. If someone has buggy code, an upgrade is going to cause a problem for them at some point. Given how unlikely the risk is -- particularly given that division is the only useful future now -- I'd say the risk is acceptable for Python 2.4.1. (Unlike, say, Python 2.4.2.)
+1 on having the fix in 2.4.1 but not in 2.3.5 -- exactly for the reasons Jeremy is giving. Alex
participants (4)
-
Alex Martelli -
Anthony Baxter -
Jeremy Hylton -
Raymond Hettinger