Hello, a few months ago i created this PR: https://github.com/python/cpython/pull/24181 Which has since gone stale, I would really like it to be reviewed before i continue fixing other issues as i do not want to have to deal with a backlog of PRs Thanks in advance, Yair.
Before looking at the code, my first question would be about the description: "I kinda ran out of time, i suspect more testing is due." If you were out of time then it's probably not done and maybe lacks the tests you initially thought it did, so did you find the time and/or is the PR done? On Tue, Jul 6, 2021 at 10:07 AM Yair Frid <fridyair@gmail.com> wrote:
Hello, a few months ago i created this PR: https://github.com/python/cpython/pull/24181 Which has since gone stale, I would really like it to be reviewed before i continue fixing other issues as i do not want to have to deal with a backlog of PRs Thanks in advance, Yair. _______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-leave@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/TYZH5DQJ... Code of Conduct: http://python.org/psf/codeofconduct/
On 7/6/2021 12:29 PM, Brian Curtin wrote:
Before looking at the code, my first question would be about the description: "I kinda ran out of time, i suspect more testing is due."
If you were out of time then it's probably not done and maybe lacks the tests you initially thought it did, so did you find the time Tests were added later the same day. The opening comment should have been edited (I made an attempt at it).
and/or is the PR done?
Asked on PR. -- Terry Jan Reedy
participants (3)
-
Brian Curtin -
Terry Reedy -
Yair Frid