operator.c for release24-maint and test_bz2 on Python 2.4.1
Hello there, The release24-maint check-ins for today contained this typo: =================================================================== RCS file: /cvsroot/python/python/dist/src/Modules/operator.c,v retrieving revision 2.29 retrieving revision 2.29.4.1 diff -u -d -r2.29 -r2.29.4.1 --- operator.c 4 Dec 2003 22:17:49 -0000 2.29 +++ operator.c 26 Aug 2005 06:43:16 -0000 2.29.4.1 @@ -267,6 +267,9 @@ itemgetterobject *ig; PyObject *item; + if (!_PyArg_NoKeywords("itemgetter()", kdws)) <----- kdws should be kwds + return NULL; + if (!PyArg_UnpackTuple(args, "itemgetter", 1, 1, &item)) return NULL; Also I wish to report that testBug1191043 of test_bz2 still fails in some cases on Python 2.4.1 on both WinXP Pro and Win98. Following is the output of the said test. #----------------------------Python 2.5a0------------------------------# # In intrepreted session mode #-----------------------------------------------------------------------------# $ python -i Python 2.5a0 (#65, Aug 26 2005, 14:57:28) [GCC 3.4.4 (mingw special)] on win32 Type "help", "copyright", "credits" or "license" for more information.
from test import test_bz2 as t t.test_main() testBug1191043 (test.test_bz2.BZ2FileTest) ... ok testIterator (test.test_bz2.BZ2FileTest) ... ok testModeU (test.test_bz2.BZ2FileTest) ... ok testOpenDel (test.test_bz2.BZ2FileTest) ... ok testOpenNonexistent (test.test_bz2.BZ2FileTest) ... ok testRead (test.test_bz2.BZ2FileTest) ... ok testRead100 (test.test_bz2.BZ2FileTest) ... ok testReadChunk10 (test.test_bz2.BZ2FileTest) ... ok testReadLine (test.test_bz2.BZ2FileTest) ... ok testReadLines (test.test_bz2.BZ2FileTest) ... ok testSeekBackwards (test.test_bz2.BZ2FileTest) ... ok testSeekBackwardsFromEnd (test.test_bz2.BZ2FileTest) ... ok testSeekForward (test.test_bz2.BZ2FileTest) ... ok testSeekPostEnd (test.test_bz2.BZ2FileTest) ... ok testSeekPostEndTwice (test.test_bz2.BZ2FileTest) ... ok testSeekPreStart (test.test_bz2.BZ2FileTest) ... ok testUniversalNewlinesCRLF (test.test_bz2.BZ2FileTest) ... ok testUniversalNewlinesLF (test.test_bz2.BZ2FileTest) ... ok testWrite (test.test_bz2.BZ2FileTest) ... ok testWriteChunks10 (test.test_bz2.BZ2FileTest) ... ok testWriteLines (test.test_bz2.BZ2FileTest) ... ok testXReadLines (test.test_bz2.BZ2FileTest) ... ok testCompress (test.test_bz2.BZ2CompressorTest) ... ok testCompressChunks10 (test.test_bz2.BZ2CompressorTest) ... ok testDecompress (test.test_bz2.BZ2DecompressorTest) ... ok testDecompressChunks10 (test.test_bz2.BZ2DecompressorTest) ... ok testDecompressUnusedData (test.test_bz2.BZ2DecompressorTest) ... ok testEOFError (test.test_bz2.BZ2DecompressorTest) ... ok test_Constructor (test.test_bz2.BZ2DecompressorTest) ... ok testCompress (test.test_bz2.FuncTest) ... ok testDecompress (test.test_bz2.FuncTest) ... ok testDecompressEmpty (test.test_bz2.FuncTest) ... ok testDecompressIncomplete (test.test_bz2.FuncTest) ... ok
---------------------------------------------------------------------- Ran 33 tests in 4.730s OK #----------------------------Python 2.4.1 from CVS ----------------# # In intrepreted session mode #-----------------------------------------------------------------------------# $ python -i Python 2.4.1 (#65, Aug 26 2005, 14:38:48) [GCC 3.4.4 (mingw special)] on win32 Type "help", "copyright", "credits" or "license" for more information.
from test import test_bz2 as t t.test_main() testBug1191043 (test.test_bz2.BZ2FileTest) ... ok testIterator (test.test_bz2.BZ2FileTest) ... ok testModeU (test.test_bz2.BZ2FileTest) ... ok testOpenDel (test.test_bz2.BZ2FileTest) ... ok testOpenNonexistent (test.test_bz2.BZ2FileTest) ... ok testRead (test.test_bz2.BZ2FileTest) ... ok testRead100 (test.test_bz2.BZ2FileTest) ... ok testReadChunk10 (test.test_bz2.BZ2FileTest) ... ok testReadLine (test.test_bz2.BZ2FileTest) ... ok testReadLines (test.test_bz2.BZ2FileTest) ... ok testSeekBackwards (test.test_bz2.BZ2FileTest) ... ok testSeekBackwardsFromEnd (test.test_bz2.BZ2FileTest) ... ok testSeekForward (test.test_bz2.BZ2FileTest) ... ok testSeekPostEnd (test.test_bz2.BZ2FileTest) ... ok testSeekPostEndTwice (test.test_bz2.BZ2FileTest) ... ok testSeekPreStart (test.test_bz2.BZ2FileTest) ... ok testUniversalNewlinesCRLF (test.test_bz2.BZ2FileTest) ... ok testUniversalNewlinesLF (test.test_bz2.BZ2FileTest) ... ok testWrite (test.test_bz2.BZ2FileTest) ... ok testWriteChunks10 (test.test_bz2.BZ2FileTest) ... ok testWriteLines (test.test_bz2.BZ2FileTest) ... ok testXReadLines (test.test_bz2.BZ2FileTest) ... ok testCompress (test.test_bz2.BZ2CompressorTest) ... ok testCompressChunks10 (test.test_bz2.BZ2CompressorTest) ... ok testDecompress (test.test_bz2.BZ2DecompressorTest) ... ok testDecompressChunks10 (test.test_bz2.BZ2DecompressorTest) ... ok testDecompressUnusedData (test.test_bz2.BZ2DecompressorTest) ... ok testEOFError (test.test_bz2.BZ2DecompressorTest) ... ok test_Constructor (test.test_bz2.BZ2DecompressorTest) ... ok testCompress (test.test_bz2.FuncTest) ... ok testDecompress (test.test_bz2.FuncTest) ... ok testDecompressEmpty (test.test_bz2.FuncTest) ... ok testDecompressIncomplete (test.test_bz2.FuncTest) ... ok
---------------------------------------------------------------------- Ran 33 tests in 5.060s OK So here we have a passing test_bz2 test when invoked from inside a running Python. #-------------------------- Python 2.4.1 from CVS -----------------# # Not in intrepreted session mode #-----------------------------------------------------------------------------# However, and in Python 2.4.1 the following happens when the test is not invoked from an interpreted session: $ python ../Lib/test/test_bz2.py testBug1191043 (__main__.BZ2FileTest) ... ERROR ERROR testIterator (__main__.BZ2FileTest) ... ok testModeU (__main__.BZ2FileTest) ... ok testOpenDel (__main__.BZ2FileTest) ... ok testOpenNonexistent (__main__.BZ2FileTest) ... ok testRead (__main__.BZ2FileTest) ... ok testRead100 (__main__.BZ2FileTest) ... ok testReadChunk10 (__main__.BZ2FileTest) ... ok testReadLine (__main__.BZ2FileTest) ... ok testReadLines (__main__.BZ2FileTest) ... ok testSeekBackwards (__main__.BZ2FileTest) ... ok testSeekBackwardsFromEnd (__main__.BZ2FileTest) ... ok testSeekForward (__main__.BZ2FileTest) ... ok testSeekPostEnd (__main__.BZ2FileTest) ... ok testSeekPostEndTwice (__main__.BZ2FileTest) ... ok testSeekPreStart (__main__.BZ2FileTest) ... ok testUniversalNewlinesCRLF (__main__.BZ2FileTest) ... ok testUniversalNewlinesLF (__main__.BZ2FileTest) ... ok testWrite (__main__.BZ2FileTest) ... ok testWriteChunks10 (__main__.BZ2FileTest) ... ok testWriteLines (__main__.BZ2FileTest) ... ok testXReadLines (__main__.BZ2FileTest) ... ok testCompress (__main__.BZ2CompressorTest) ... ok testCompressChunks10 (__main__.BZ2CompressorTest) ... ok testDecompress (__main__.BZ2DecompressorTest) ... ok testDecompressChunks10 (__main__.BZ2DecompressorTest) ... ok testDecompressUnusedData (__main__.BZ2DecompressorTest) ... ok testEOFError (__main__.BZ2DecompressorTest) ... ok test_Constructor (__main__.BZ2DecompressorTest) ... ok testCompress (__main__.FuncTest) ... ok testDecompress (__main__.FuncTest) ... ok testDecompressEmpty (__main__.FuncTest) ... ok testDecompressIncomplete (__main__.FuncTest) ... ok ====================================================================== ERROR: testBug1191043 (__main__.BZ2FileTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "../Lib/test/test_bz2.py", line 255, in testBug1191043 lines = bz2f.readlines() RuntimeError: wrong sequence of bz2 library commands used ====================================================================== ERROR: testBug1191043 (__main__.BZ2FileTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "../Lib/test/test_bz2.py", line 47, in tearDown os.unlink(self.filename) OSError: [Errno 13] Permission denied: '@test' ---------------------------------------------------------------------- Ran 33 tests in 6.210s FAILED (errors=2) Traceback (most recent call last): File "../Lib/test/test_bz2.py", line 357, in ? test_main() File "../Lib/test/test_bz2.py", line 353, in test_main FuncTest File "G:\PROJS\PY24\PYTHON\DIST\SRC\lib\test\test_support.py", line 290, in run_unittest run_suite(suite, testclass) File "G:\PROJS\PY24\PYTHON\DIST\SRC\lib\test\test_support.py", line 274, in run_suite raise TestFailed(msg) test.test_support.TestFailed: errors occurred; run in verbose mode for details #-------------------------- Python 2.5a0 from CVS -----------------# # Not in intrepreted session mode #-----------------------------------------------------------------------------# That problem disappears in Python 2.5a0: $ python ../Lib/test/test_bz2.py testBug1191043 (__main__.BZ2FileTest) ... ok testIterator (__main__.BZ2FileTest) ... ok testModeU (__main__.BZ2FileTest) ... ok testOpenDel (__main__.BZ2FileTest) ... ok testOpenNonexistent (__main__.BZ2FileTest) ... ok testRead (__main__.BZ2FileTest) ... ok testRead100 (__main__.BZ2FileTest) ... ok testReadChunk10 (__main__.BZ2FileTest) ... ok testReadLine (__main__.BZ2FileTest) ... ok testReadLines (__main__.BZ2FileTest) ... ok testSeekBackwards (__main__.BZ2FileTest) ... ok testSeekBackwardsFromEnd (__main__.BZ2FileTest) ... ok testSeekForward (__main__.BZ2FileTest) ... ok testSeekPostEnd (__main__.BZ2FileTest) ... ok testSeekPostEndTwice (__main__.BZ2FileTest) ... ok testSeekPreStart (__main__.BZ2FileTest) ... ok testUniversalNewlinesCRLF (__main__.BZ2FileTest) ... ok testUniversalNewlinesLF (__main__.BZ2FileTest) ... ok testWrite (__main__.BZ2FileTest) ... ok testWriteChunks10 (__main__.BZ2FileTest) ... ok testWriteLines (__main__.BZ2FileTest) ... ok testXReadLines (__main__.BZ2FileTest) ... ok testCompress (__main__.BZ2CompressorTest) ... ok testCompressChunks10 (__main__.BZ2CompressorTest) ... ok testDecompress (__main__.BZ2DecompressorTest) ... ok testDecompressChunks10 (__main__.BZ2DecompressorTest) ... ok testDecompressUnusedData (__main__.BZ2DecompressorTest) ... ok testEOFError (__main__.BZ2DecompressorTest) ... ok test_Constructor (__main__.BZ2DecompressorTest) ... ok testCompress (__main__.FuncTest) ... ok testDecompress (__main__.FuncTest) ... ok testDecompressEmpty (__main__.FuncTest) ... ok testDecompressIncomplete (__main__.FuncTest) ... ok ---------------------------------------------------------------------- Ran 33 tests in 5.880s OK Regards Khalid _________________________________________________________________ Express yourself instantly with MSN Messenger! Download today it's FREE! http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/
A.B., Khalid wrote:
Hello there,
The release24-maint check-ins for today contained this typo:
=================================================================== RCS file: /cvsroot/python/python/dist/src/Modules/operator.c,v retrieving revision 2.29 retrieving revision 2.29.4.1 diff -u -d -r2.29 -r2.29.4.1 --- operator.c 4 Dec 2003 22:17:49 -0000 2.29 +++ operator.c 26 Aug 2005 06:43:16 -0000 2.29.4.1 @@ -267,6 +267,9 @@ itemgetterobject *ig; PyObject *item;
+ if (!_PyArg_NoKeywords("itemgetter()", kdws)) <----- kdws should be kwds + return NULL; + if (!PyArg_UnpackTuple(args, "itemgetter", 1, 1, &item)) return NULL;
Thank you, that is corrected now.
However, and in Python 2.4.1 the following happens when the test is not invoked from an interpreted session:
$ python ../Lib/test/test_bz2.py testBug1191043 (__main__.BZ2FileTest) ... ERROR ERROR
[...]
====================================================================== ERROR: testBug1191043 (__main__.BZ2FileTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "../Lib/test/test_bz2.py", line 255, in testBug1191043 lines = bz2f.readlines() RuntimeError: wrong sequence of bz2 library commands used
====================================================================== ERROR: testBug1191043 (__main__.BZ2FileTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "../Lib/test/test_bz2.py", line 47, in tearDown os.unlink(self.filename) OSError: [Errno 13] Permission denied: '@test'
---------------------------------------------------------------------- Ran 33 tests in 6.210s
FAILED (errors=2) Traceback (most recent call last): File "../Lib/test/test_bz2.py", line 357, in ? test_main() File "../Lib/test/test_bz2.py", line 353, in test_main FuncTest File "G:\PROJS\PY24\PYTHON\DIST\SRC\lib\test\test_support.py", line 290, in run_unittest run_suite(suite, testclass) File "G:\PROJS\PY24\PYTHON\DIST\SRC\lib\test\test_support.py", line 274, in run_suite raise TestFailed(msg) test.test_support.TestFailed: errors occurred; run in verbose mode for details
Are you sure that you are calling the newly-built python.exe? It is strange that the test should pass in interactive mode when it doesn't in normal mode. For a confirmation, can you execute this piece of code both interactively and from a file: data = 'BZh91AY&SY\xd9b\x89]\x00\x00\x00\x03\x80\x04\x00\x02\x00\x0c\x00 \x00!\x9ah3M\x13<]\xc9\x14\xe1BCe\x8a%t' f = open('test.bz2', "wb") f.write(data) f.close() bz2f = BZ2File('test.bz2') lines = bz2f.readlines() bz2f.close() assert lines == ['Test'] bz2f = BZ2File('test.bz2) xlines = list(bz2f.xreadlines()) bz2f.close() assert lines == ['Test'] os.unlink('test.bz2') Reinhold -- Mail address is perfectly valid!
participants (2)
-
A.B., Khalid
-
Reinhold Birkenfeld