Re: [Python-Dev] [Python-checkins] cpython: Fix email post-commit review comments.
On Wed, Apr 18, 2012 at 11:31 PM, brian.curtin <python-checkins@python.org> wrote:
- if (name == NULL) + if (name == NULL) { + Py_INCREF(Py_None); name = Py_None; + }
A slightly more traditional way to write that would be: name = Py_None; Py_INCREF(name);
- if (path == NULL) + if (path == NULL) { + Py_INCREF(Py_None); path = Py_None; + }
Ditto.
Py_INCREF(msg); - PyTuple_SetItem(args, 0, msg); + PyTuple_SetItem(args, 0, NULL);//msg);
However, *this* looks a lot more suspicious... accidental commit of debugging code? (if not for spotting this last problem, I wouldn't have even mentioned the first two) Cheers, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
We're seeing segfuilts on the buildbots now. Example: http://www.python.org/dev/buildbot/all/builders/x86%20Ubuntu%20Shared%203.x/... On Wed, 18 Apr 2012 23:39:34 +1000, Nick Coghlan <ncoghlan@gmail.com> wrote:
On Wed, Apr 18, 2012 at 11:31 PM, brian.curtin <python-checkins@python.org> wrote:
- if (name == NULL) + if (name == NULL) { + Py_INCREF(Py_None); name = Py_None; + }
A slightly more traditional way to write that would be:
name = Py_None; Py_INCREF(name);
- if (path == NULL) + if (path == NULL) { + Py_INCREF(Py_None); path = Py_None; + }
Ditto.
Py_INCREF(msg); - PyTuple_SetItem(args, 0, msg); + PyTuple_SetItem(args, 0, NULL);//msg);
However, *this* looks a lot more suspicious... accidental commit of debugging code?
(if not for spotting this last problem, I wouldn't have even mentioned the first two)
Cheers, Nick.
-- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/rdmurray%40bitdance.com
participants (2)
-
Nick Coghlan -
R. David Murray