Re: [Python-Dev] cpython: Cleanup the docs ElementTree a bit and describe the default_namespace
On 13.01.13 16:28, eli.bendersky wrote:
http://hg.python.org/cpython/rev/f0e80c7404a5 changeset: 81490:f0e80c7404a5 user: Eli Bendersky <eliben@gmail.com> date: Sun Jan 13 06:27:51 2013 -0800 summary: Cleanup the docs ElementTree a bit and describe the default_namespace parameter. In the code, replace the old outdated Doxygen-ish comment above ElementTree.write by a proper docstring.
I think that wrong documentation of ElementTree.write is a bug and should be fixed in early Python versions too.
And perhaps it will be better if parameters will be described in same order as they enumerated in the signature (now 'default_namespace' described after 'method').
On Sun, Jan 13, 2013 at 7:31 AM, Serhiy Storchaka <storchaka@gmail.com>wrote:
And perhaps it will be better if parameters will be described in same order as they enumerated in the signature (now 'default_namespace' described after 'method').
Serhiy, both you comments make sense. But: 1. A better place to "park" them is an issue (the original issue for which the commits were made, or even a new issue). 2. Feel free to use your newly gained superpowers to help out with such fixes. Often a quick fix + commit doesn't take much longer than to write an email. Eli
______________________________**_________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/**mailman/listinfo/python-dev<http://mail.python.org/mailman/listinfo/python-dev> Unsubscribe: http://mail.python.org/**mailman/options/python-dev/** eliben%40gmail.com<http://mail.python.org/mailman/options/python-dev/eliben%40gmail.com>
On 13.01.13 19:28, Eli Bendersky wrote:
1. A better place to "park" them is an issue (the original issue for which the commits were made, or even a new issue).
I agree. Usually I do this, except for the cases when the issue number is not specified in the commit message.
2. Feel free to use your newly gained superpowers to help out with such fixes. Often a quick fix + commit doesn't take much longer than to write an email.
I didn't want to come in your heels. Now, when you have approved it and left it for me, I'll do it.
participants (2)
-
Eli Bendersky -
Serhiy Storchaka