Requesting PR review on locale module
Hi, Few months ago, I submitted a PR [1] for the bpo [2] about locale.format casting Decimal into float. Has someone some times to finish the review? This change is blocking a bugfix on Tryton [3]. [1] https://github.com/python/cpython/pull/15275 [2] https://bugs.python.org/issue34311 [3] https://bugs.tryton.org/issue8574 Thanks, -- Cédric Krier - B2CK SPRL Email/Jabber: cedric.krier@b2ck.com Tel: +32 472 54 46 59 Website: http://www.b2ck.com/
Hi Cédric, Thanks for writing and sorry that you've experienced such a delay. Such occurrences are unfortunately rather common right now, though we're working on improving the situation. Stéphane Wirtel self-assigned that PR to himself a couple of months ago, but indeed hasn't followed it up after his requested changes were apparently addressed, despite a couple of "pings". The experts index[1] lists Marc-Andre Lemburg as the expert for the locale module, so perhaps he'd be interested in taking a look. I've CC-ed both Stéphane and Marc-Andre. [1] https://devguide.python.org/experts/ On Sun, Nov 17, 2019 at 2:06 PM Cédric Krier via Python-Dev < python-dev@python.org> wrote:
Hi,
Few months ago, I submitted a PR [1] for the bpo [2] about locale.format casting Decimal into float. Has someone some times to finish the review? This change is blocking a bugfix on Tryton [3].
[1] https://github.com/python/cpython/pull/15275 [2] https://bugs.python.org/issue34311 [3] https://bugs.tryton.org/issue8574
Thanks, -- Cédric Krier - B2CK SPRL Email/Jabber: cedric.krier@b2ck.com Tel: +32 472 54 46 59 Website: http://www.b2ck.com/ _______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-leave@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/UOGIZADI... Code of Conduct: http://python.org/psf/codeofconduct/
Hi Cedric, It’s my fault, I am going to check your PR for this week. I am really sorry because I am busy with the preparation of my black belt in Karate and I have a training every day. Have a nice day, Stéphane
Le 17 nov. 2019 à 14:06, Tal Einat <taleinat@gmail.com> a écrit :
Hi Cédric,
Thanks for writing and sorry that you've experienced such a delay. Such occurrences are unfortunately rather common right now, though we're working on improving the situation.
Stéphane Wirtel self-assigned that PR to himself a couple of months ago, but indeed hasn't followed it up after his requested changes were apparently addressed, despite a couple of "pings".
The experts index[1] lists Marc-Andre Lemburg as the expert for the locale module, so perhaps he'd be interested in taking a look.
I've CC-ed both Stéphane and Marc-Andre.
[1] https://devguide.python.org/experts/
On Sun, Nov 17, 2019 at 2:06 PM Cédric Krier via Python-Dev <python-dev@python.org> wrote: Hi,
Few months ago, I submitted a PR [1] for the bpo [2] about locale.format casting Decimal into float. Has someone some times to finish the review? This change is blocking a bugfix on Tryton [3].
[1] https://github.com/python/cpython/pull/15275 [2] https://bugs.python.org/issue34311 [3] https://bugs.tryton.org/issue8574
Thanks, -- Cédric Krier - B2CK SPRL Email/Jabber: cedric.krier@b2ck.com Tel: +32 472 54 46 59 Website: http://www.b2ck.com/ _______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-leave@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/UOGIZADI... Code of Conduct: http://python.org/psf/codeofconduct/
Hi, Any chance to get this PR reviewed? It is blocking the resolution of https://bugs.tryton.org/issue8574 Thanks On 2019-11-18 06:36, Stéphane Wirtel wrote:
Hi Cedric,
It’s my fault, I am going to check your PR for this week. I am really sorry because I am busy with the preparation of my black belt in Karate and I have a training every day.
Have a nice day,
Stéphane
Le 17 nov. 2019 à 14:06, Tal Einat <taleinat@gmail.com> a écrit :
Hi Cédric,
Thanks for writing and sorry that you've experienced such a delay. Such occurrences are unfortunately rather common right now, though we're working on improving the situation.
Stéphane Wirtel self-assigned that PR to himself a couple of months ago, but indeed hasn't followed it up after his requested changes were apparently addressed, despite a couple of "pings".
The experts index[1] lists Marc-Andre Lemburg as the expert for the locale module, so perhaps he'd be interested in taking a look.
I've CC-ed both Stéphane and Marc-Andre.
[1] https://devguide.python.org/experts/
On Sun, Nov 17, 2019 at 2:06 PM Cédric Krier via Python-Dev <python-dev@python.org> wrote: Hi,
Few months ago, I submitted a PR [1] for the bpo [2] about locale.format casting Decimal into float. Has someone some times to finish the review? This change is blocking a bugfix on Tryton [3].
[1] https://github.com/python/cpython/pull/15275 [2] https://bugs.python.org/issue34311 [3] https://bugs.tryton.org/issue8574
Thanks, -- Cédric Krier - B2CK SPRL Email/Jabber: cedric.krier@b2ck.com Tel: +32 472 54 46 59 Website: http://www.b2ck.com/ _______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-leave@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/UOGIZADI... Code of Conduct: http://python.org/psf/codeofconduct/
-- Cédric Krier - B2CK SPRL Email/Jabber: cedric.krier@b2ck.com Tel: +32 472 54 46 59 Website: https://www.b2ck.com/
I've verified this fix and changed the status to "commit review." I trust that was the correct action. Kind regards, Steve Holden On Thu, Jan 9, 2020 at 9:57 PM Cédric Krier via Python-Dev < python-dev@python.org> wrote:
Hi,
Any chance to get this PR reviewed? It is blocking the resolution of https://bugs.tryton.org/issue8574
Thanks
Hi Cedric,
It’s my fault, I am going to check your PR for this week. I am really sorry because I am busy with the preparation of my black belt in Karate and I have a training every day.
Have a nice day,
Stéphane
Le 17 nov. 2019 à 14:06, Tal Einat <taleinat@gmail.com> a écrit :
Hi Cédric,
Thanks for writing and sorry that you've experienced such a delay. Such occurrences are unfortunately rather common right now, though we're working on improving the situation.
Stéphane Wirtel self-assigned that PR to himself a couple of months ago, but indeed hasn't followed it up after his requested changes were apparently addressed, despite a couple of "pings".
The experts index[1] lists Marc-Andre Lemburg as the expert for the locale module, so perhaps he'd be interested in taking a look.
I've CC-ed both Stéphane and Marc-Andre.
[1] https://devguide.python.org/experts/
On Sun, Nov 17, 2019 at 2:06 PM Cédric Krier via Python-Dev <
On 2019-11-18 06:36, Stéphane Wirtel wrote: python-dev@python.org> wrote:
Hi,
Few months ago, I submitted a PR [1] for the bpo [2] about locale.format casting Decimal into float. Has someone some times to finish the review? This change is blocking a bugfix on Tryton [3].
[1] https://github.com/python/cpython/pull/15275 [2] https://bugs.python.org/issue34311 [3] https://bugs.tryton.org/issue8574
Thanks, -- Cédric Krier - B2CK SPRL Email/Jabber: cedric.krier@b2ck.com Tel: +32 472 54 46 59 Website: http://www.b2ck.com/ _______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-leave@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/UOGIZADI... Code of Conduct: http://python.org/psf/codeofconduct/
-- Cédric Krier - B2CK SPRL Email/Jabber: cedric.krier@b2ck.com Tel: +32 472 54 46 59 Website: https://www.b2ck.com/ _______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-leave@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/RFY3DCK4... Code of Conduct: http://python.org/psf/codeofconduct/
participants (4)
-
Cédric Krier -
Steve Holden -
Stéphane Wirtel -
Tal Einat