On Wed, Apr 23, 2003 at 07:48:06PM +0200, Thomas Heller wrote:

Neal Norwitz writes:

...

Some test failures are:

test_getargs2 Solaris 8, Mac OS X

It seems test_getargs2 fails on big endian platforms. Is the solaris 8 such a machine?

I believe so.

See also the comments I added to http://www.python.org/sf/724774.

I have the impression that the test is broken. Should I try to fix it (difficult, without access to neither Mac or Solaris), or should it simply be deleted ;-)

I think getargs_ul() is broken. For example, if the user passes more than a single char as the format, memory will be scribbled on. The format should be checked to make sure it contains acceptable values for getargs_ul() to be safe. I fixed a similar problem in revision 1.23 of _testcapimodule.c. See comment and code around line 330. I'm not really sure of the purpose of _testcapimodule, so perhaps the lack of error checking is acceptable? I can fix the problems, but not before the beta will go out. Neal

Neal Norwitz writes:

I think getargs_ul() is broken. For example, if the user passes more than a single char as the format, memory will be scribbled on. The format should be checked to make sure it contains acceptable values for getargs_ul() to be safe.

I fixed a similar problem in revision 1.23 of _testcapimodule.c. See comment and code around line 330.

I've replaced the getargs_ul() function and friends with new getargs_X() functions for all the tested format codes. I've also adapted test_getargs2 to use these new functions. Skip and Jack have offered to test this, anyone else is welcome as well to report crashes. Thomas

Skip Montanaro writes:

Thomas> I have the impression that the test is broken. Should I try to Thomas> fix it (difficult, without access to neither Mac or Solaris), or Thomas> should it simply be deleted ;-)

I have access to both Mac OS X and Solaris 8. I routinely build from CVS on my Mac Laptop (my default Python interpreter there is built from CVS). I can set up a CVS tree on a Solaris 8 machine and test anything you need.

In this case I'll try to fix it tomorrow. Thanks, Thomas