Re: [Python-Dev] hooks: Add roundup integration hook.
8 Mar
2011
8 Mar
'11
8:19 a.m.
On Tue, 08 Mar 2011 12:23:54 +0100
local
+ +VERBS = r'(?:\b(?P<verb>close[sd]?|closing|fixe[sd]|fixing|fix)\s+)?' +ISSUE_PATTERN = re.compile(r'%s(?:#|\bissue|\bbug)\s*(?P
[0-9]+)' + % VERBS, re.I)
This should only match numbers with 4 and 5 figures IMO. Otherwise things like "this is priority #1" in commit messages will spam issue number 1 (assuming it exists). Also, I'm not sure trying to match too many verbs is useful. Things are clearer and more predictible if we mandate a single form, perhaps only at the last line of the commit message. We don't want false positives (such as messages about closed files, etc.). Regards Antoine.
4769
Age (days ago)
4769
Last active (days ago)
1 comments
2 participants
participants (2)
-
Antoine Pitrou
-
Georg Brandl