
Hi all, Having been active in bug triage and patch writing/reviewing since late 2009, it was suggested in the python-dev IRC channel that I request commit access to the repository. I'm primarily a Windows user and have worked with many of the other active contributors to diagnose issues and test patches when they don't have direct access to Windows. Brian Curtin p.s. My contributor form in on file as of 2010-01-31.

Brian Curtin wrote:
Having worked with Brian at PyCon and via email, I support this. Especially if it can be done soon so he can work on committing http://bugs.python.org/issue1578269, which I have not had time to focus on. -- Eric.

Procedurally, I wonder where people got the notion from that you can or need to apply for commit access. IIUC, it used to be the case that you would be recommended for commit access, by some (more or less senior) fellow committer. That person then would work on actually getting commit access to the new committer - perhaps by first asking other people in private, to avoid any public embarrassment if access is ultimately denied. IMO, that committer should then also mentor the new guy, both by helping out in difficult cases, and by closely following commits to see whether (possibly unstated) conventions are being followed. I'm not really picking on Brian here specifically, I just want to point out that I dislike this (apparent) change in process, primarily because of the risk of embarrassment. With all that said: I'm also fine with giving access to Brian (in particular due to the endorsements that have already been posted). I still would like somebody to step forward as a mentor, and I would need Brian to send me his SSH key. Regards, Martin

Martin v. Löwis <martin <at> v.loewis.de> writes:
For the record, I'm not opposing any point you are making, but all this is not clearly written out, and I think that's why people (including me) lately have been thinking that the candidate for commit rights had to declare himself on this mailing-list. If the process goes differently, it probably deserves documenting somewhere. Regards Antoine.

Am 23.03.2010 23:01, schrieb Antoine Pitrou:
I don't think it is "wrong" to do it this way -- but of course the hopeful new committer needs to be prepared for a "no". I still would like every new committer to have a "mentor" from the pool of more experienced committers; however for people who are very active on IRC like Brian, there's usually one of the around to review a patch before it is committed. Georg

On Wed, Mar 24, 2010 at 12:34 AM, "Martin v. Löwis" <martin@v.loewis.de> wrote:
That's an ideal case, but it doesn't work, because more or less senior committers are already too busy. If they do not even have time to review issues, followup on patches - how can they monitor who reached the appropriate karma level? -- anatoly t.

The practice proves to be different. In the recent additions, the new developer had been approached by some committer, suggesting that they apply. So the initiative actually started from a committer who thought that the karma level was appropriate. All I'm asking for is that then this committer takes the issues in his own hands, rather than letting the new developer ask for himself. Regards, Martin

Martin v. Löwis wrote:
Agreed, since there is a bit of a commitment on the sponsor's part to help coach the new committer in the early days (most new committers don't need much coaching, but it's still good practice to have a specific existing committer looking at their work for a while, in addition to those of us that just try to review everything that goes by on the checkin list). Cheers, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia ---------------------------------------------------------------

Martin v. Löwis wrote:
That sounds like it should be the preferred procedure, but it may be that Brian was advised to ask by an existing committer who didn't feel they had the "authority" to recommend him. In such an event (or if committers are too busy to action a promising candidate) I don't see anything wrong with a candidate asking directly (as long as they are prepared to put up with a semi-public discussion of their application's merits). regards Steve -- Steve Holden +1 571 484 6266 +1 800 494 3119 See PyCon Talks from Atlanta 2010 http://pycon.blip.tv/ Holden Web LLC http://www.holdenweb.com/ UPCOMING EVENTS: http://holdenweb.eventbrite.com/

Brian Curtin wrote:
Having worked with Brian at PyCon and via email, I support this. Especially if it can be done soon so he can work on committing http://bugs.python.org/issue1578269, which I have not had time to focus on. -- Eric.

Procedurally, I wonder where people got the notion from that you can or need to apply for commit access. IIUC, it used to be the case that you would be recommended for commit access, by some (more or less senior) fellow committer. That person then would work on actually getting commit access to the new committer - perhaps by first asking other people in private, to avoid any public embarrassment if access is ultimately denied. IMO, that committer should then also mentor the new guy, both by helping out in difficult cases, and by closely following commits to see whether (possibly unstated) conventions are being followed. I'm not really picking on Brian here specifically, I just want to point out that I dislike this (apparent) change in process, primarily because of the risk of embarrassment. With all that said: I'm also fine with giving access to Brian (in particular due to the endorsements that have already been posted). I still would like somebody to step forward as a mentor, and I would need Brian to send me his SSH key. Regards, Martin

Martin v. Löwis <martin <at> v.loewis.de> writes:
For the record, I'm not opposing any point you are making, but all this is not clearly written out, and I think that's why people (including me) lately have been thinking that the candidate for commit rights had to declare himself on this mailing-list. If the process goes differently, it probably deserves documenting somewhere. Regards Antoine.

Am 23.03.2010 23:01, schrieb Antoine Pitrou:
I don't think it is "wrong" to do it this way -- but of course the hopeful new committer needs to be prepared for a "no". I still would like every new committer to have a "mentor" from the pool of more experienced committers; however for people who are very active on IRC like Brian, there's usually one of the around to review a patch before it is committed. Georg

On Wed, Mar 24, 2010 at 12:34 AM, "Martin v. Löwis" <martin@v.loewis.de> wrote:
That's an ideal case, but it doesn't work, because more or less senior committers are already too busy. If they do not even have time to review issues, followup on patches - how can they monitor who reached the appropriate karma level? -- anatoly t.

The practice proves to be different. In the recent additions, the new developer had been approached by some committer, suggesting that they apply. So the initiative actually started from a committer who thought that the karma level was appropriate. All I'm asking for is that then this committer takes the issues in his own hands, rather than letting the new developer ask for himself. Regards, Martin

Martin v. Löwis wrote:
Agreed, since there is a bit of a commitment on the sponsor's part to help coach the new committer in the early days (most new committers don't need much coaching, but it's still good practice to have a specific existing committer looking at their work for a while, in addition to those of us that just try to review everything that goes by on the checkin list). Cheers, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia ---------------------------------------------------------------

Martin v. Löwis wrote:
That sounds like it should be the preferred procedure, but it may be that Brian was advised to ask by an existing committer who didn't feel they had the "authority" to recommend him. In such an event (or if committers are too busy to action a promising candidate) I don't see anything wrong with a candidate asking directly (as long as they are prepared to put up with a semi-public discussion of their application's merits). regards Steve -- Steve Holden +1 571 484 6266 +1 800 494 3119 See PyCon Talks from Atlanta 2010 http://pycon.blip.tv/ Holden Web LLC http://www.holdenweb.com/ UPCOMING EVENTS: http://holdenweb.eventbrite.com/
participants (11)
-
"Martin v. Löwis"
-
anatoly techtonik
-
Antoine Pitrou
-
Brian Curtin
-
Dirkjan Ochtman
-
Eric Smith
-
Ezio Melotti
-
Georg Brandl
-
Nick Coghlan
-
R. David Murray
-
Steve Holden