Re: [Python-checkins] CVS: python/dist/src/Objects dictobject.c,2.65,2.66
Aargh! I thought I told you to submit a patch (to SF), not to check it in. The code looks okay but we'll have to discuss whether we really want all three (as opposed to only firstitem()). I'm also not sure whether KeyError might be a better exception. Don't touch it for now, but let's think this over a bit. --Guido van Rossum (home page: http://www.python.org/~guido/)
"GvR" == Guido van Rossum <guido@python.org> writes:
GvR> Aargh! I thought I told you to submit a patch (to SF), not GvR> to check it in. GvR> The code looks okay but we'll have to discuss whether we GvR> really want all three (as opposed to only firstitem()). I'm GvR> also not sure whether KeyError might be a better exception. GvR> Don't touch it for now, but let's think this over a bit. And don't forget that when we /do/ decide on the right thing, that UserDict needs to map <ha ha> the change too. -Barry
"GvR" == Guido van Rossum <guido@python.org> writes:
GvR> Aargh! I thought I told you to submit a patch (to SF), not GvR> to check it in. GvR> The code looks okay but we'll have to discuss whether we GvR> really want all three (as opposed to only firstitem()). I'm GvR> also not sure whether KeyError might be a better exception. GvR> Don't touch it for now, but let's think this over a bit. And don't forget that when we /do/ decide on the right thing, that UserDict needs to map <ha ha> the change too. -Barry
participants (2)
-
barry＠digicool.com -
Guido van Rossum