[Chris Withers]

...

Barry usually takes ownership of changes to the email package. Do you have patches ready for him to review?

Not yet for 1974, but given that I submitted a patch for this issue:

http://bugs.python.org/issue4308

...some months ago, and nothing has happened with it, I want to get a bit more pro-active, hence the question in the subject line ;-)

Being proactive with that package probably means submitting patches and waiting. When there are active module maintainers, other contributors (including committers) generally refrain from committing semantic changes and defer to the package owner (effbot for ElementTree, Barry for email, Ippolito for json, Vinay for logging, Skip and Barry for csv, me for itertools and collections, Kurt for IDLE, etc). The process can be maddenly slow (waiting for an owner to have the time and inclination) but it has its advantages over the long-term. Raymond

Chris Withers wrote:

But still, no answer to my original question...

Largely, by being patient and waiting :) As to what you're actually waiting for - usually for an existing developer to suggest granting you commit privileges. The exact reasons an existing developer may suggest that are many and varied - a significant history of accepted patches is certainly one way, as is a long history contributing to python-dev. Assisting with triage and patch reviews on the tracker is another good one. There are occasional exceptions, such as when a new module is adopted for the standard library and the developer is granted commit privileges to support that module, or when a new maintainer steps forward for a somewhat neglected area of the standard library. Mainly though, it's a question of "Hurry up and wait!". Cheers, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia ---------------------------------------------------------------

Christian> CPython has a stricter policy than most other Python related Christian> projects. Indeed. I'd be willing to grant you checkin privileges for SpamBayes simply because because Christian recognized you and you seem willing to roll up your sleeves. Do you do Windows? <wink> Skip

>> Indeed. I'd be willing to grant you checkin privileges for SpamBayes >> simply because because Christian recognized you and you seem willing >> to roll up your sleeves. Do you do Windows? <wink> Chris> The irony that Thunderbird put this in my spam folder based on Chris> its heuristics is not lost on me ;-) So, when can you start? :-) S

On Mon, Mar 2, 2009 at 7:26 AM, Chris Withers <chris@simplistix.co.uk> wrote:

skip@pobox.com wrote:

...

   >> Indeed.  I'd be willing to grant you checkin privileges for SpamBayes    >> simply because because Christian recognized you and you seem willing    >> to roll up your sleeves. Do you do Windows?  <wink>

   Chris> The irony that Thunderbird put this in my spam folder based on    Chris> its heuristics is not lost on me ;-)

So, when can you start? :-)

When the test and patch attached to this issue get committed:

http://bugs.python.org/issue4308

I'd like to jump in and vouch for Chris. I've known him for many years and while we haven't worked closely I expect he'd be a valuable contributor. So +1 from me for giving Chris commit privileges for core Python. (Chris, I assume you'll go through an apprentice phase where you'll be letting another committer review your changes before you commit them yourself. Rietveld at codereview.appspot.com should be helpful for getting your code reviewed. (Just use upload.py instead of the Create Issue form. :-) -- --Guido van Rossum (home page: http://www.python.org/~guido/)

On Thu, Mar 5, 2009 at 01:08, Chris Withers <chris@simplistix.co.uk> wrote:

Guido van Rossum wrote:

...

I'd like to jump in and vouch for Chris. I've known him for many years and while we haven't worked closely I expect he'd be a valuable contributor. So +1 from me for giving Chris commit privileges for core Python.

Thanks :-) I can't promise how *much* time I'll be able to give, but when I do have itches, I'll certainly be scratching them...

(Chris, I assume you'll go through an apprentice phase where

...

you'll be letting another committer review your changes before you commit them yourself.

How does Python work w.r.t. to dev? I'm used to the branch/merge pattern:

- create branch, say chris.withers-issue4308 - do work on that branch - request code review - merge branch to appropriate release branches and trunk - delete branch

If this isn't the pattern Python uses, why isn't it? ;-)

Because Python started out on CVS and then moved to svn and just never picked up the branching religion. But there is nothing wrong with creating a branch in the sandbox and doing work there; just isn't common practice for anything that isn't going to be a long term project.

Rietveld at codereview.appspot.com should be

...

helpful for getting your code reviewed. (Just use upload.py instead of the Create Issue form. :-)

OK, although I'd prefer the branch/merge pattern, less toolage required...

Right, but that still doesn't preclude the usefulness of being able to leave comments in Rietveld for a reviewer. -Brett

Barry Warsaw wrote:

Chris, are you going to be at Pycon? I'm sorry I haven't had time to review email package changes. I will try to take a look this weekend, but if you're going to be at Pycon perhaps we can find some sprinting time?

Sure, I'm around for the whole conference once I'm done giving my tutorial. I fly out Monday 30th in the afternoon, so any time before then. The one currently causing me to scream is why a MIME Multipart container which has a MIMText containing html and a MIMEBase containing a PDF added to it ends up with a Content-Transfer-Encoding of quoted-printable. Should it even have a Content-Transfer-Encoding header given that it has no text of its own? Where would I look to see where this header gets generated in Python 2.4.4? (the problem is that this is in violation of RFC2045 and makes some MTAs do stupid things that result in blank messages arriving: http://docs.sun.com/app/docs/doc/819-4428/geuxh?a=view) cheers, Chris -- Simplistix - Content Management, Zope & Python Consulting - http://www.simplistix.co.uk