Hello again. A lot of overflow tests fail in the testsuite, by expecting overflow using sys.maxint. for example this line, 196, in test_index.py: self.assertEqual(x[self.neg:self.pos], (-1, maxint)) At the moment, I am disabling these tests with if "64 bit" not in sys.version: So, two questions: Should we add something like sys.maxsize to keep these overflow tests valid? Also, some tests just kill the computer when given large values, that are expected to overflow. Sometimes it would be good to test for a 64 bit machine with virtually infinite ram. Is there a better way than the "64 bit" in sys.version test? Should we have something like sys.bits? Kristján
this is 1<<63 on those machines? If that is the case, I have two suggestions: a) Propagate the Windows idiom of sizeof(size_t) != sizeof(long) by keeping some sys.maxsize for list length, indices, etc. b) Elevate int to 64 bits on windows too! B is probably a huge change. Not only change PyIntObject but probably create some Py_int and so on. Ok, b) is not a real suggestion, then.
And use those in the testsuite... K
this is 1<<63 on those machines? If that is the case, I have two suggestions: a) Propagate the Windows idiom of sizeof(size_t) != sizeof(long) by keeping some sys.maxsize for list length, indices, etc. b) Elevate int to 64 bits on windows too! B is probably a huge change. Not only change PyIntObject but probably create some Py_int and so on. Ok, b) is not a real suggestion, then.
And use those in the testsuite... K
participants (5)
-
"Martin v. Löwis" -
Armin Rigo -
Kristján Valur Jónsson -
Thomas Heller -
Žiga Seilnacht