I've also got a change to PEP 8 (for basestring). Is the wording ok? Should I check it in or should Barry/Guido? Also, it seems that PEP 42 is a bit out of date. I think the stat/statvfs changes may be done (at least started), the std library uses 4 space indents, math.radians/degrees were added. Probably others too. Neal -- Index: pep-0008.txt =================================================================== RCS file: /cvsroot/python/python/nondist/peps/pep-0008.txt,v retrieving revision 1.13 diff -C1 -r1.13 pep-0008.txt *** pep-0008.txt 29 May 2002 16:07:27 -0000 1.13 --- pep-0008.txt 3 Jun 2002 20:25:54 -0000 *************** *** 542,548 **** When checking if an object is a string, keep in mind that it ! might be a unicode string too! In Python 2.2, the types module ! has the StringTypes type defined for that purpose, e.g.: ! from types import StringTypes: ! if isinstance(strorunicodeobj, StringTypes): --- 542,547 ---- When checking if an object is a string, keep in mind that it ! might be a unicode string too! In Python 2.3, str and unicode ! have a common base class, basestring, so you can do: ! if isinstance(strorunicodeobj, basestring):
I've also got a change to PEP 8 (for basestring). Is the wording ok? Should I check it in or should Barry/Guido?
You can check it in, but I suggest providing ways of doing this for 2.0/2.1, 2.2, and 2.3 (since they are all different).
Also, it seems that PEP 42 is a bit out of date. I think the stat/statvfs changes may be done (at least started), the std library uses 4 space indents, math.radians/degrees were added. Probably others too.
Whoever fulfilled those wishes should ideally edit the PEP. You can do it too. --Guido van Rossum (home page: http://www.python.org/~guido/)
"NN" == Neal Norwitz
writes:
NN> I've also got a change to PEP 8 (for basestring). Is the NN> wording ok? Should I check it in or should Barry/Guido? I would add the Python 2.3 recommendation to the PEP instead of replacing the Python 2.2 recommendation. If you do that, feel free to commit the change. -Barry
participants (3)
-
barry@zope.com
-
Guido van Rossum
-
Neal Norwitz